make config-loading debug messages more explicit #703

Merged
merged 1 commit into from Aug 16, 2011

Projects

None yet

2 participants

@minrk
Member
minrk commented Aug 16, 2011

It was never clear in debug messages that the cwd is searched
for config files. This adjusts various debug messages during
config-file loading to make things more clear.

The following debug messages were added:

  • specify search-path at start of load-config routine
  • on success, full path of loaded config files
  • always note when config files are not found
@minrk minrk make config-loading debug messages more explicit
It was never clear in debug messages that the cwd is searched
for config files.  This adjusts various debug messages during
config-file loading to make things more clear:

The following debug messages were added:
* specify search-path at start of load-config routine
* on success, full path of loaded config files
* always note when config files are not found
b9a348b
@fperez
Member
fperez commented Aug 16, 2011

Hey Min,

On Mon, Aug 15, 2011 at 5:48 PM, minrk
reply@reply.github.com
wrote:

It was never clear in debug messages that the cwd is searched
for config files.  This adjusts various debug messages during
config-file loading to make things more clear.

The following debug messages were added:

  • specify search-path at start of load-config routine
  • on success, full path of loaded config files
  • always note when config files are not found

Didn't you mean in application.py this?

self.log.error("Exception while loading config file %s" %
                            filename, exc_info=True)

otherwise the signature for the error call is wrong, no? (note the %
instead of the comma at the end of the first line).

Cheers,

f

ps - I tried leaving this as an inline comment, but github is having
trouble right now, connection errors, so email is safer for now.

@fperez
Member
fperez commented Aug 16, 2011

On Mon, Aug 15, 2011 at 6:09 PM, Fernando Perez fperez.net@gmail.com wrote:

Didn't you mean in application.py this?

self.log.error("Exception while loading config file %s" %
                           filename, exc_info=True)

otherwise the signature for the error call is wrong, no? (note the %
instead of the comma at the end of the first line).

BTW, if the above is OK, the rest looks good, so merge away otherwise.

Thanks!

f

@minrk
Member
minrk commented Aug 16, 2011

Yes, it is generally advisable to not use '%' in log messages. Using a comma means the formatting is not evaluated unless the message will actually be displayed, but the resulting message is the same.

@fperez
Member
fperez commented Aug 16, 2011

Great, then merge away!

@fperez fperez merged commit fbc50c4 into ipython:master Aug 16, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment