doc improvements for running notebook via secure protocol #730

Merged
merged 3 commits into from Aug 25, 2011

3 participants

@satra

No description provided.

@fperez fperez commented on an outdated diff Aug 25, 2011
IPython/frontend/html/notebook/notebookapp.py
@@ -263,7 +263,12 @@ class IPythonNotebookApp(BaseIPythonApplication):
def start(self):
ip = self.ip if self.ip else '[all ip addresses on your system]'
- self.log.info("The IPython Notebook is running at: http://%s:%i" % (ip, self.port))
+ proto = 'http'
+ if self.certfile:
+ proto = 'https'
+ self.log.info("The IPython Notebook is running at: %s://%s:%i" % (proto,
@fperez
IPython member
fperez added a note Aug 25, 2011

Since we're on 2.6, this can be more compactly written in the new form:

proto = 'https' if self.certfile else 'http'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@fperez
IPython member

This is great, thanks! Once this minor fix is made, I'll go ahead and merge.

@ellisonbg ellisonbg merged commit e9402c0 into ipython:master Aug 25, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment