Check for tornado before running frontend.html tests. #748

Merged
merged 1 commit into from Sep 6, 2011

Projects

None yet

4 participants

@ellisonbg
Member

Please test to make sure this solves the issue.

@jdmarch
jdmarch commented Aug 30, 2011

All tests now pass in OSX 10.6 and Ubuntu 10.4.
In Win7, the tornado failures are gone. There is still one (pre-existing, apparently unrelated) test failure which I will report separately.

@minrk
Member
minrk commented Aug 31, 2011

@ellisonbg - do you want to test for tornado 2.0, rather than just tornado? The server itself requires it, but I'm not sure if the tests would.

@ellisonbg
Member

I don't think we need to do that. The top-level classes/functions
that are used at import are not changing very quickly and really
import just requires that they exist, not that their implementation
does anything specific.

On Wed, Aug 31, 2011 at 1:24 PM, minrk
reply@reply.github.com
wrote:

@ellisonbg - do you want to test for tornado 2.0, rather than just tornado?  The server itself requires it, but I'm not sure if the tests would.

Reply to this email directly or view it on GitHub:
#748 (comment)

Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com

@takluyver
Member

That solves the problem for me. I think you can merge this.

@ellisonbg ellisonbg merged commit 3651423 into ipython:master Sep 6, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment