restore msg_id/msg_type aliases in top level of msg dict #754

Merged
merged 1 commit into from Sep 6, 2011

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Sep 2, 2011

msg_id/type must continue to be stored in the header, as only the header/parent/content are actually sent over the wire. But the msg_id and msg_type should remain as aliases in the top-level msg dict, for logical reasons and continued 0.11 compatibility.

Docs and tests updated to match.

Supercedes PR #753

restore msg_id/msg_type aliases in top level of msg dict
msg_id/type must be stored in the header, as only the header/parent/content are actually sent over the wire.  But the msg_id and msg_type should remain as aliases in the top-level msg dict, for logic and 0.11 compatibility.

* docs and tests updated to match.
@ellisonbg

This comment has been minimized.

Show comment
Hide comment
@ellisonbg

ellisonbg Sep 6, 2011

Member

Looks good, I am going to merge.

Member

ellisonbg commented Sep 6, 2011

Looks good, I am going to merge.

ellisonbg added a commit that referenced this pull request Sep 6, 2011

Merge pull request #754 from minrk/msg_id
restore msg_id/msg_type aliases in top level of msg dict

@ellisonbg ellisonbg merged commit 7ff2814 into ipython:master Sep 6, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #754 from minrk/msg_id
restore msg_id/msg_type aliases in top level of msg dict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment