Skip to content
This repository

ipython.el is broken in 0.11 #757

Closed
wants to merge 1 commit into from

2 participants

Pedro Kroger Min RK
Pedro Kroger

Hi,

ipython.el 0.11 will fail to load because the syntax for --colors is different. This patch fixes it.

Min RK
Owner

Not knowing anything about emacs or lisp, but this seems simple enough and correct, so we should merge (even though the fix is no longer needed in master).

Brian E. Granger ellisonbg referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Sep 03, 2011
Pedro Kroger Use new command line syntax for colors d2d967a
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 10 additions and 10 deletions. Show diff stats Hide diff stats

  1. +10 10 docs/emacs/ipython.el
20 docs/emacs/ipython.el
@@ -36,7 +36,7 @@
36 36 ;; always in ``pylab`` mode with hardcoded light-background colors, you can
37 37 ;; use::
38 38 ;;
39   -;; (setq py-python-command-args '("-pylab" "--colors" "LightBG"))
  39 +;; (setq py-python-command-args '("-pylab" "--colors=LightBG"))
40 40 ;;
41 41 ;;
42 42 ;; NOTE: This mode is currently somewhat alpha and although I hope that it
@@ -220,14 +220,14 @@ the second for a 'normal' command, and the third for a multiline command.")
220 220 (unless (member "--colors" py-python-command-args)
221 221 (setq py-python-command-args
222 222 (nconc py-python-command-args
223   - (list "--colors"
224   - (cond
225   - ((eq frame-background-mode 'dark)
226   - "Linux")
227   - ((eq frame-background-mode 'light)
228   - "LightBG")
229   - (t ; default (backg-mode isn't always set by XEmacs)
230   - "LightBG"))))))
  223 + (list (concat "--colors="
  224 + (cond
  225 + ((eq frame-background-mode 'dark)
  226 + "Linux")
  227 + ((eq frame-background-mode 'light)
  228 + "LightBG")
  229 + (t ; default (backg-mode isn't always set by XEmacs)
  230 + "LightBG")))))))
231 231 (unless (equal ipython-backup-of-py-python-command py-python-command)
232 232 (setq ipython-backup-of-py-python-command py-python-command))
233 233 (setq py-python-command ipython-command))
@@ -351,7 +351,7 @@ in the current *Python* session."
351 351 (process-send-string python-process
352 352 (format ipython-completion-command-string pattern))
353 353 (accept-process-output python-process)
354   -
  354 +
355 355 ;(message (format "DEBUG return: %s" ugly-return))
356 356 (setq completions
357 357 (split-string (substring ugly-return 0 (position ?\n ugly-return)) sep))

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.