Set context for shortcuts in ConsoleWidget #763

Merged
merged 1 commit into from Sep 7, 2011

Projects

None yet

4 participants

@punchagan

The default value of Qt.WindowShortcut causes a problem when IPython is embedded as a widget in other applications.

Setting the shortcut context to Qt.WidgetWithChildrenShortcut

@minrk
IPython member

I don't think this commit does what you think it does. It just deletes almost all of console_widget.py

@punchagan

I'm sorry. I was trying the new editor of GitHub and seems like one of my browser plugins + the editor created some problems.

I pushed the correct changes, now. Thanks!

@jdmarch

Works for me, OSX and Windows 7.

@epatters

These shortcuts should never have been added to ConsoleWidget in the first place, as shortcuts for printing and saving are an application-level matter. At some point, they should be moved out of ConsoleWidget and into QtConsoleApp.

I don't have time to refactor this now, though, so I'm going to merge this. Thanks for the fix, @punchagan.

@epatters epatters merged commit ac6d8ef into ipython:master Sep 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment