fix "--colors=<color>" option in py-python-command-args. #764

Merged
merged 1 commit into from Sep 7, 2011

Projects

None yet

2 participants

@tchaikov
Contributor
tchaikov commented Sep 6, 2011

fix "--colors=" option in py-python-command-args. otherwise ipython is launched with "-i --colors LightBG" arguments.

@minrk
Member
minrk commented Sep 6, 2011

How does this differ from existing PR #757?

@tchaikov
Contributor
tchaikov commented Sep 6, 2011

PR #757 tells if user specifies his/her own color scheme by looking at the py-python-command-args as my patch does. That's correct. But if user follows the the new syntax, it won't work as expect. Because:

(member "--colors" py-python-command-args)

fails to match --colors=LightBG. while my patch matches the arguments with (string-match "^--colors=*" x) where string-match matches the elements in the argument list with a regular expression of ^--color=* . That's the right way to go, IMHO.

Other than this, we are basically the same. And I am sending PR #765 in which I replace all tab with four spaces.

@tchaikov
Contributor
tchaikov commented Sep 6, 2011

just re-submitted PR #766 which is better formatted and more concise.

@minrk
Member
minrk commented Sep 6, 2011

You don't need to keep reissuing pull requests, they are not static. If you push again to the same branch, it will change the pull request. You can clobber existing changes with push -f.

@tchaikov
Contributor
tchaikov commented Sep 6, 2011

thanks a lot. minrk. =)

I just pushed the latest commit.

@minrk minrk and 1 other commented on an outdated diff Sep 6, 2011
docs/emacs/ipython.el
@@ -36,7 +36,7 @@
;; always in ``pylab`` mode with hardcoded light-background colors, you can
;; use::
;;
-;; (setq py-python-command-args '("-pylab" "--colors" "LightBG"))
+;; (setq py-python-command-args '("-pylab" "--colors=LightBG"))
@minrk
minrk Sep 6, 2011 Member

While you are fixing args, you might fix '-pylab' to '--pylab'. '-pylab' is technically allowed, but throws a deprecation warning, because it doesn't match the existing pattern.

@tchaikov
tchaikov Sep 7, 2011 Contributor

thanks. fixed.

@tchaikov tchaikov fix "--colors=<color>" option in py-python-command-args. otherwise ip…
…ython is launched with "-i --colors LightBG" arguments.
4d5cb6d
@minrk
Member
minrk commented Sep 7, 2011

Okay, then I'll go ahead and merge, as this seems straightforward and useful.

@minrk minrk merged commit db29245 into ipython:master Sep 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment