Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
pexpect & Python 3 #798
These look fine to merge, but I'd suggest you split it into two separate commits. Since one entails changes to an external dependency, I think it's best to always have those available in nice, isolated commits. It makes it easier to send the patch upstream, reapply it if we update to a new version from upstream that doesn't have the changes, etc.
So my vote is: rebase by splitting into two commits, one for each file, then merge away.
OK, I've split them, but I found another minor bug. The kernel in Python 2 has a
On the principle that most systems now can handle a superset of ascii (either utf-8 or a Windows code page), I've made
I think that the object which is now used for sys.stdin (
I don't think it should cause problems, because: