Skip to content

Py3 notebook #801

Merged
merged 3 commits into from Oct 8, 2011

2 participants

@takluyver
IPython member

It was surprisingly easy to get the notebook code running under Python 3.

@ellisonbg, there was a bytestring/unicode mismatch somewhere that I didn't properly investigate - I just stuck in the quick fix you can see in handlers.py. Let me know if there's a better place to solve it.

Saving the notebook isn't working (it complains about invalid JSON), and my testing was rather brief, but this does at least allow the notebook to start under Python 3.

@takluyver
IPython member

And saving notebooks now works in Python 3 too. I've assumed the PUT requests to save the notebook will always be UTF-8 encoded - let me know if that assumption is invalid.

@fperez
IPython member
fperez commented Oct 8, 2011

This code looks clean and I don't see any problems with the notebooks on py2, so I'm merging for now; I trust you on the py3 part and all of this just improves things on py3 anyway...

@fperez fperez merged commit 8ffab04 into ipython:master Oct 8, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.