Python3 setup.py install failiure #848

Merged
merged 2 commits into from Oct 9, 2011

Conversation

Projects
None yet
3 participants
@jenshnielsen
Contributor

jenshnielsen commented Oct 9, 2011

I have problems running python3 setup.py build on the latest git head using ubuntu 11.10.

2to3 fails with errors like:
Can't parse docstring in build/lib/IPython/core/usage.py line 195: ParseError: bad input: type=1, value='arg1', context=(' ', (195, 12))

This happens because of to different issues:
In IPython/parallel/client/view.py there is an unbalanced (

In IPython/core/usage.py the automagic docstrings are not valid python code (Thats the point I guess)
To fix this I changed the prompts from regular python prompts to ipython ones. But I guess the right fix should be to have 2to3 skip the parsing on these strings.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Oct 9, 2011

Member

Odd, I'm building it semi regularly with Ubuntu 11.10, and I haven't had any problems.

Member

takluyver commented Oct 9, 2011

Odd, I'm building it semi regularly with Ubuntu 11.10, and I haven't had any problems.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Oct 9, 2011

Member

OK, apparently it works differently outside a virtualenv for some reason. Not sure why, maybe it's a different version of distribute.

Anyway, these changes looks sensible. Thanks.

Member

takluyver commented Oct 9, 2011

OK, apparently it works differently outside a virtualenv for some reason. Not sure why, maybe it's a different version of distribute.

Anyway, these changes looks sensible. Thanks.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Oct 9, 2011

Member

I don't see a problem here, but @takluyver is our resident py3 expert, so I'd like to leave the final call on this one up to him. But as far as I can tell, it's good to go, thanks! (though as a note, I did test python3 setup.py build on ubuntu 11.10 just now, and didn't see any errors; but further cleanups won't hurt in any case).

Member

fperez commented Oct 9, 2011

I don't see a problem here, but @takluyver is our resident py3 expert, so I'd like to leave the final call on this one up to him. But as far as I can tell, it's good to go, thanks! (though as a note, I did test python3 setup.py build on ubuntu 11.10 just now, and didn't see any errors; but further cleanups won't hurt in any case).

takluyver added a commit that referenced this pull request Oct 9, 2011

Merge pull request #848 from jenshnielsen/python3
Python3 setup.py install failiure

@takluyver takluyver merged commit 52688c2 into ipython:master Oct 9, 2011

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Oct 9, 2011

Member

Merged - thanks, Jens.

@fperez: It seems it works in a virtualenv, but not outside (at least for me). Maybe different versions of distribute are getting imported. Anyway, the changes make sense and don't break the test suite.

Member

takluyver commented Oct 9, 2011

Merged - thanks, Jens.

@fperez: It seems it works in a virtualenv, but not outside (at least for me). Maybe different versions of distribute are getting imported. Anyway, the changes make sense and don't break the test suite.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Oct 9, 2011

Member

Weird: I wasn't running in a virtualenv, just running 'in plain sight' :) But in any case, I agree with you; I just wanted your OK on it given the py3 focus. Thanks!

Member

fperez commented Oct 9, 2011

Weird: I wasn't running in a virtualenv, just running 'in plain sight' :) But in any case, I agree with you; I just wanted your OK on it given the py3 focus. Thanks!

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

Merge pull request #848 from jenshnielsen/python3
Python3 setup.py install failiure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment