promote aliases and flags, to ensure they have priority over config files #855

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@minrk
Member
minrk commented Oct 11, 2011

See #849

adds Application.flatten_flags() method, which adjusts the alias
and flag dicts, such that they point to the subclass in the Application.classes list when passed to the argv parser.

This prevents TerminalInteractiveShell.colors in a config file overriding
--colors on the command-line, which points to InteractiveShell.colors.

Flattening is only done when the answer is unambiguous, so multiply inherited classes (e.g. Launchers in ipcluster) are not touched.

also removes now-obsolete manual workaround for exactly this in IPClusterStart

closes gh-849

@minrk minrk promote aliases and flags, to ensure they have priority over config f…
…iles

add Application.flatten_flags() method, which adjusts the alias
and flag dicts, such that they point to the subclass in the Application.classes list when passed to the argv parser.

This prevents TerminalInteractiveShell.colors in a config file overriding
`--colors` on the command-line, which points to InteractiveShell.colors.

Flattening is only done when the answer is unambiguous, so multiply inherited classes (e.g. Launchers in ipcluster) are not touched.

also remove now-obsolete manual workaround for this in IPClusterStart

closes gh-849
d7a1059
@fperez
Member
fperez commented Oct 13, 2011

Great, thanks! Merged with rebase to avoid recursive merge for just one commit, closing.

@fperez fperez closed this Oct 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment