Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Warn user if MathJax can't be fetched from notebook closes #744 #868

Merged
merged 3 commits into from

3 participants

@Carreau
Owner

just put this in notebook.html

There was an issues trying to fetch MathJax.js from the internet. You might
wan't to consider using "install_mathjax()" to be able to use the Notebook
fonctionnality offline

And hide it at <body>'s onload if window.mathjax found.

IPython/frontend/html/notebook/templates/notebook.html
@@ -49,6 +56,12 @@
<span id="kernel_status">Idle</span>
</div>
+<div id="MatjaxFetchingWarning">
+ There was an issues trying to fetch MathJax.js from the internet. You might
@fperez Owner
fperez added a note

typo: issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
IPython/frontend/html/notebook/templates/notebook.html
@@ -49,6 +56,12 @@
<span id="kernel_status">Idle</span>
</div>
+<div id="MatjaxFetchingWarning">
+ There was an issues trying to fetch MathJax.js from the internet. You might
+ wan't to consider using "install_mathjax()" to be able to use the Notebook
@fperez Owner
fperez added a note

s/wan't/want/

The instructions should say instead:

You may want to consider running "from IPython.external import mathjax; mathjax.install_mathjax()" in order to be able to use the Notebook. Note that this will require a working internet connection when run, and it will try to install MathJax into the directory where you installed IPython. If you installed IPython to a location that requires administrative privileges to write, you will need to make this call as an administrator. On OSX/Linux/Unix, this can be done at the command-line via 'sudo python -c "from IPython.external import mathjax; mathjax.install_mathjax"'.

This will be much clearer and directly useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
IPython/frontend/html/notebook/templates/notebook.html
@@ -12,6 +12,13 @@
<!-- <script type="text/javascript" src="http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_HTML" charset="utf-8"></script> -->
<script type='text/javascript' src='static/mathjax/MathJax.js?config=TeX-AMS_HTML' charset='utf-8'></script>
+ <script language="Javascript">
@fperez Owner
fperez added a note

shouldn't this be merged with the next script section immediately below, which is also about mathjax anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@Carreau Carreau Matjax Warning message improvement.
	merge '<script>' balises.
	Improve message text and style.
	Remove instead of hide
5a3b5ce
@Carreau
Owner

Fixed,
with some styling inlined in HTML.
I've also change from hide to removeChild

IPython/frontend/html/notebook/templates/notebook.html
@@ -12,7 +12,13 @@
<!-- <script type="text/javascript" src="http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_HTML" charset="utf-8"></script> -->
<script type='text/javascript' src='static/mathjax/MathJax.js?config=TeX-AMS_HTML' charset='utf-8'></script>
- <script type="text/javascript">
+ <script language="Javascript">
@minrk Owner
minrk added a note

As I understand it, language="javascript" is deprecated, and type="text/javascript" is officially the way to declare script type.

@Carreau Owner
Carreau added a note

I've never done javascript before, so I trust you.

@minrk Owner
minrk added a note

No worries, I didn't know either, but when I saw the inconsistency I Google'd it. We are pretty much all js novices here.

@fperez Owner
fperez added a note
@Carreau Owner
Carreau added a note

Very true. It took me 2hours last night to get CodeMirror to toggle
line-numbers on a per cell basis :) (pull request coming soon after I
clean it up a little).

I though I was the only one :-)

Question: are we ready to merge this one, or is further cleanup needed?

Might want to test on IE6 ?
Add a message for people with JS not activated ?

@fperez Owner
fperez added a note
@Carreau Owner
Carreau added a note

IE was a joke of course.
I have no idea how to add a message that will be visible only to browser without JS, without having it "poping up" for a few millisecond for user having JS...

@minrk Owner
minrk added a note

Note that you can't even get to the notebook page without js, since our whole UI (including the frontpage) is jQuery.

A single line of plaintext 'IPython notebook requires javascript' shouldn't be bothersome. I don't think there's any need for more information than that these days.

@minrk Owner
minrk added a note

Also a reason our pre-load warning messages may linger longer than others is that MathJax is huge, so loading up a notebook page can take a significant fraction of a second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@minrk
Owner

This looks good, but as it is, you can see the MathJax warning briefly on every notebook load. We should only draw the warning when the MathJax test fails, so initially it should have display:none, and add to the check:

    function CheckMathJax(){
        var div=document.getElementById("MatjaxFetchingWarning");
        if(window.MathJax){
            document.body.removeChild(div);
        }else{
            div.style.display = "block";
        }
    }
@Carreau
Owner

True, I was still thinking as if it would be executed after mathjax.js was loaded... and that the 'else' would then never be executed

@fperez fperez merged commit 7a1207e into ipython:master
@fperez
Owner

Thanks a lot for the work! Made some minor edits to the message before pushing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 13, 2011
  1. @Carreau
Commits on Oct 14, 2011
  1. @Carreau

    Matjax Warning message improvement.

    Carreau authored
    	merge '<script>' balises.
    	Improve message text and style.
    	Remove instead of hide
  2. @Carreau

    Hide warning message about matjax when page load

    Carreau authored
    	also fix Matjax->MathJax
This page is out of date. Refresh to see the latest.
Showing with 28 additions and 1 deletion.
  1. +28 −1 IPython/frontend/html/notebook/templates/notebook.html
View
29 IPython/frontend/html/notebook/templates/notebook.html
@@ -13,6 +13,15 @@
<!-- <script type="text/javascript" src="http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_HTML" charset="utf-8"></script> -->
<script type='text/javascript' src='static/mathjax/MathJax.js?config=TeX-AMS_HTML' charset='utf-8'></script>
<script type="text/javascript">
+ function CheckMathJax(){
+ var div=document.getElementById("MathJaxFetchingWarning")
+ if(window.MathJax){
+ document.body.removeChild(div)
+ }
+ else{
+ div.style.display = "block";
+ }
+ }
if (typeof MathJax == 'undefined') {
console.log("No local MathJax, loading from CDN");
document.write(unescape("%3Cscript type='text/javascript' src='http://cdn.mathjax.org/mathjax/latest/MathJax.js%3Fconfig=TeX-AMS_HTML' charset='utf-8'%3E%3C/script%3E"));
@@ -37,7 +46,7 @@
</head>
-<body>
+<body onload='CheckMathJax();'>
<div id="header">
<span id="ipython_notebook"><h1>IPython Notebook</h1></span>
@@ -49,6 +58,24 @@
<span id="kernel_status">Idle</span>
</div>
+<div id="MathJaxFetchingWarning" style="width:80%;margin:auto;padding-top:20%;text-align:justify;display:none">
+ <p style="font-size:26px;">There was an issues trying to fetch MathJax.js from the internet.</p>
+ <p>You may want to consider running the following in order to be able to use the Notebook.
+ <pre style="background-color:lightblue;border:thin silver solid">
+ from IPython.external import mathjax; mathjax.install_mathjax()
+ </pre>
+ Note that this will require a working internet connection when run, and
+ it will try to install MathJax into the directory where you installed
+ IPython. If you installed IPython to a location that requires
+ administrative privileges to write, you will need to make this call as
+ an administrator. On OSX/Linux/Unix, this can be done at the
+ command-line via:
+ <pre style="background-color:lightblue;border:thin silver solid">
+ sudo python -c "from IPython.external import mathjax; mathjax.install_mathjax()"
+ </pre>
+ </p>
+</div>
+
<div id="main_app">
<div id="left_panel">
Something went wrong with that request. Please try again.