a user is not notified when saving a notebook fails. I've implemented a small pop-up to fix this. Please review the changes and send me any comments.
Update document title and last_saved_name only after a successful save.
Notify the user of errors when saving a notebook.
Fixed testing of new notebook name before saving.
This is great! The notebook frontend still has yet to add error handling/reporting for most failures, but this is probably the most important.
This looks good to me, thanks a lot! @minrk, did you have anything further in mind or should we go ahead with the merge?
Merge remote-tracking branch 'upstream/master'
It looks good to me.
@fwerner: could you remove that last commit ad50083? It's best not to push a merge from upsteram into the pull request, as it will make the final commit graph more complicated than necessary. You can fix the issue by doing, in your local copy of this branch:
git reset --hard c0c597c
git push --force
That will remove that final merge operation so we can bring your work into master without back-and-forth merges.
We can just merge the previous commit, there's no need for him to rollback
@minrk, was it fully ready to merge? In that case I agree, no need for @fwerner to do a rollback. Just let me know and I can do it (or go ahead and do it yourself).
Notify user if notebook save fails.
The saving failed message in again pretty brief and not very visible, having the pop up back would be cool. Could Someone reopen ?
Well, for some reason I can't reopen right now. Either the wifi I'm on is really bad, or github is having a problem...
This is a Pull Request, not a regular Issue. We don't actually want to reopen it.
Ah, right.. I should stop trying to manage ipython while in a conference with 10 other things going on, sorry...