Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

- There is a bug when running the profiler in the magic command (prun) with python3 #901

Closed
wants to merge 1 commit into from

3 participants

@alcidesv
%run -p <...> . And this is an attempt to solve it.

I'm not sure if this is the correct way to handle it.

Regards.

@alcidesv alcidesv - There is a bug when running the profiler in the magic command
    %run -p <...> . And this is an attempt to solve it.
687bebd
@alcidesv

Oh, I didn't notice this is the wrong repos! My apologies!

@alcidesv alcidesv closed this
@takluyver takluyver reopened this
@takluyver
Owner

It's OK, this actually is the right place for it now. After 0.11, we merged the Python 3 support in, so this code (which will become 0.12) should now install on Python 2 or Python 3.

I think this looks like a pretty sound approach.

@fperez
Owner

@takluyver, I'll leave it up to you to review/merge this one, since it's on the py3 territory. Let me know if you want a 2nd look on anything. @dsign, thanks for the contribution!

@takluyver
Owner

It looks fine, I'm just going to run a few tests before I merge it. Actually, it's probably a good candidate for adding an automated test. @dsign, do you want to do that? Have a look in IPython/core/tests/test_run.py. It needn't be complex, just check that doing %run -p succeeds.

@alcidesv

No problem, I will take care of it.

@takluyver
Owner

Great, thanks.

@alcidesv

Any hints as how to run a particular case in the test suite? The full test runs more or less o,k, but for individual tests I keep getting something about

global name 'get_ipython' is not defined

thanks in advance.

@alcidesv alcidesv closed this
@takluyver takluyver reopened this
@takluyver
Owner

Yes, there's some awkward trickery we do to inject get_ipython into the builtin namespace for the test suite. There's a way to specify it in the options to iptest, something like iptest IPython.core.tests.test_run:test_run_p. I normally just specify the package: iptest IPython.core, which takes a few seconds to run the tests.

@alcidesv

Please follow up on:

#916

I had deleted the original branch :-(

@alcidesv alcidesv closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 19, 2011
  1. @alcidesv

    - There is a bug when running the profiler in the magic command

    alcidesv authored
        %run -p <...> . And this is an attempt to solve it.
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 1 deletion.
  1. +5 −1 IPython/core/magic.py
View
6 IPython/core/magic.py
@@ -1382,7 +1382,11 @@ def magic_prun(self, parameter_s ='',user_mode=1,
return
arg_str = 'execfile(filename,prog_ns)'
- namespace = locals()
+ namespace = {
+ 'execfile': self.shell.safe_execfile,
+ 'filename': filename,
+ 'prog_ns': prog_ns
+ }
opts.merge(opts_def)
Something went wrong with that request. Please try again.