reincarnate -V cmdline option #926

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@yarikoptic
Contributor

yarikoptic commented Oct 24, 2011

please allow at least to check for version consistently with previous versions.
Since -V is not used by anything else, please let it stay. You could spit out
deprecation warning meanwhile to discourage its use, but it remains the only way
to check which version of ipython is actually available from the cmdline (might
be useful to scripts/mode wrappers for editors etc)

allow for consistent version checking with previous releases of ipython
please allow at least to check for version consistently with previous versions.
Since -V is not used by anything else, please let it stay.  You could spit out
deprecation warning meanwhile to discourage its use, but it remains the only way
to check which version of ipython is actually available from the cmdline (might
be useful to scripts/mode wrappers for editors etc)
@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Oct 24, 2011

Member

Entirely sensible. Of course, as with most python packages, the following always works:

python -c "import IPython; print IPython.__version__"

Which you would have to do if you want your test to allow for 0.11, which lacks this fix.

Member

minrk commented Oct 24, 2011

Entirely sensible. Of course, as with most python packages, the following always works:

python -c "import IPython; print IPython.__version__"

Which you would have to do if you want your test to allow for 0.11, which lacks this fix.

@yarikoptic

This comment has been minimized.

Show comment
Hide comment
@yarikoptic

yarikoptic Oct 24, 2011

Contributor

grhm -- I feel silly now -- I should have indeed just relied on that ... feel free to 'close' without adopting/merging ;)

Contributor

yarikoptic commented Oct 24, 2011

grhm -- I feel silly now -- I should have indeed just relied on that ... feel free to 'close' without adopting/merging ;)

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Oct 24, 2011

Member

No worries, I think it's still valid and tiny change. No need to have excessive incompatibility, especially for methods specifically for checking compatibility.

Member

minrk commented Oct 24, 2011

No worries, I think it's still valid and tiny change. No need to have excessive incompatibility, especially for methods specifically for checking compatibility.

@fperez

This comment has been minimized.

Show comment
Hide comment
@fperez

fperez Oct 25, 2011

Member

+1, merge away (with rebase to avoid recursive merge for a single commit). @yarikoptic, note also that at the cmd line, --version should also work..

Member

fperez commented Oct 25, 2011

+1, merge away (with rebase to avoid recursive merge for a single commit). @yarikoptic, note also that at the cmd line, --version should also work..

@minrk minrk closed this in df951f4 Oct 25, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

restore '-V' cmdline option for printing version
Preserves compatibility with pre-0.11 call, which was broken unnecessarily.

closes gh-926
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment