Cancel in qt console closeevent should trigger event.ignore() #933

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jenshnielsen
Contributor

When quitting ipython using for example the file quit option ipython quits even if you press cancel.
This pull request fixes that by inserting event.ignore() in the code the runs when cancel is pressed
and indenting the event.accept() so that it is only triggered when the yes button is pressed.

From the qt documentation and tutorials that I could find this seems to be the right way of using closeevent.

@minrk
Member
minrk commented Oct 26, 2011

makes sense.

@epatters
Contributor

I committed this without a merge, but GitHub hasn't clued in. Thanks for the fix!

@epatters epatters closed this Oct 26, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment