add wantDirectory to ipdoctest, so that directories will be checked for e #968

Closed
wants to merge 1 commit into from

2 participants

@minrk
IPython member

add wantDirectory to ipdoctest, so that directories will be checked for exclusion

This prevents ImportErrors raised in __init__ checks from causing a failure when they should have been excluded.

closes gh-918

@minrk minrk add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
c3bd3dc
@takluyver
IPython member

I'm not familiar with nose's architecture, but it looks OK (and I assume you've tested it). Although I might have used the any() function to do the same thing.

@minrk
IPython member

Thanks, merging - any() does make sense, and might be trivially cleaner (though technically less efficient).

This code is just copied/pasted from directly above - it's exactly the same as the file exclusion, just in the separate method that is used for directories (which appears to be the only way to protect code in __init__).

@minrk minrk added a commit that closed this pull request Nov 10, 2011
@minrk minrk add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
closes gh-968
c956c22
@minrk minrk closed this in c956c22 Nov 10, 2011
@mattvonrocketstein mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
@minrk minrk add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
closes gh-968
e2d2de5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment