add wantDirectory to ipdoctest, so that directories will be checked for e #968

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@minrk
Member

minrk commented Nov 2, 2011

add wantDirectory to ipdoctest, so that directories will be checked for exclusion

This prevents ImportErrors raised in __init__ checks from causing a failure when they should have been excluded.

closes gh-918

add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Nov 10, 2011

Member

I'm not familiar with nose's architecture, but it looks OK (and I assume you've tested it). Although I might have used the any() function to do the same thing.

Member

takluyver commented Nov 10, 2011

I'm not familiar with nose's architecture, but it looks OK (and I assume you've tested it). Although I might have used the any() function to do the same thing.

@minrk

This comment has been minimized.

Show comment
Hide comment
@minrk

minrk Nov 10, 2011

Member

Thanks, merging - any() does make sense, and might be trivially cleaner (though technically less efficient).

This code is just copied/pasted from directly above - it's exactly the same as the file exclusion, just in the separate method that is used for directories (which appears to be the only way to protect code in __init__).

Member

minrk commented Nov 10, 2011

Thanks, merging - any() does make sense, and might be trivially cleaner (though technically less efficient).

This code is just copied/pasted from directly above - it's exactly the same as the file exclusion, just in the separate method that is used for directories (which appears to be the only way to protect code in __init__).

@minrk minrk closed this in c956c22 Nov 10, 2011

mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014

add wantDirectory to ipdoctest, so that directories will be checked f…
…or exclusion

This prevents ImportErrors raised in `__init__` checks from causing a failure when they should have been excluded.

closes gh-918
closes gh-968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment