preserve margins when using Ctrl-O for newline #9770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should address ipython#9588. Control-O will insert a new line, preserve the current cursor position and preserve the indentation level on the newline
|
@njsmith -- do you want to try this out and see if it meets your needs? |
| @@ -56,6 +56,10 @@ def register_ipython_shortcuts(registry, shell): | |||
| & cursor_in_leading_ws | |||
| ))(indent_buffer) | |||
|
|
|||
| registry.add_binding(Keys.ControlO, | |||
| filter=(HasFocus(DEFAULT_BUFFER) | |||
| & insert_mode))(newline_with_copy_margin) | |||
There was a problem hiding this comment.
I guess that the filter probably needs to check for Emacs mode too.
|
@takluyver -- I think this is ready for another look. I removed the |
|
Thanks. Yes, I think that works - EmacsInsertMode should be effectively emacs & insert. |
|
@njsmith I have given this a quick test, but I'd like you to test that it actually behaves as you want. |
|
Marking as 5.1 |
|
Ok, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #9588. Control-O will insert a new
line, preserve the current cursor position and preserve the indentation
level on the newline