Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use __qualname__ on Python 2, as it does not exists. #9804

Merged
merged 2 commits into from Jul 25, 2016

Conversation

@Carreau
Copy link
Member

Carreau commented Jul 25, 2016

Closes #9756

@Carreau
Copy link
Member Author

Carreau commented Jul 25, 2016

Assigning @michaelpacer for review.

@mpacer
Copy link
Member

mpacer commented Jul 25, 2016

Looks like your logic for checking the python version number is backwards > (3,) not < (3,)

@Carreau Carreau force-pushed the Carreau:qualname branch from cb0162e to 622b6cf Jul 25, 2016
@Carreau
Copy link
Member Author

Carreau commented Jul 25, 2016

Fixed. Good catch,

@Carreau
Copy link
Member Author

Carreau commented Jul 25, 2016

Travis is happy.

@Carreau
Copy link
Member Author

Carreau commented Jul 25, 2016

@michaelpacer if you are happy with that, you can +1 an I can self-merge. You'll get commit rights soon enough.

@Carreau Carreau self-assigned this Jul 25, 2016
@Carreau
Copy link
Member Author

Carreau commented Jul 25, 2016

Ok, codecov is annoying as failing PRs, so merging this.

@Carreau Carreau merged commit c44d5f5 into ipython:master Jul 25, 2016
3 checks passed
3 checks passed
codecov/patch 0.00% of diff hit (target 0.00%)
Details
codecov/project 73.23% (-1.02%) compared to f4d0d99
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau Carreau deleted the Carreau:qualname branch May 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.