Don't use __qualname__ on Python 2, as it does not exists. #9804

Merged
merged 2 commits into from Jul 25, 2016

Projects

None yet

2 participants

@Carreau
Member
Carreau commented Jul 25, 2016

Closes #9756

@Carreau Carreau added this to the 5.1 milestone Jul 25, 2016
@Carreau
Member
Carreau commented Jul 25, 2016

Assigning @michaelpacer for review.

@michaelpacer
Contributor

Looks like your logic for checking the python version number is backwards > (3,) not < (3,)

Carreau added some commits Jul 25, 2016
@Carreau Carreau Don't use __qualname__ on Python 2, as it does not exists.
Closes #9756
7b12b9f
@Carreau Carreau Add codecov file, its apparently only way ton configure now.
622b6cf
@Carreau
Member
Carreau commented Jul 25, 2016 edited

Fixed. Good catch,

@Carreau
Member
Carreau commented Jul 25, 2016

Travis is happy.

@Carreau
Member
Carreau commented Jul 25, 2016

@michaelpacer if you are happy with that, you can +1 an I can self-merge. You'll get commit rights soon enough.

@Carreau Carreau self-assigned this Jul 25, 2016
@Carreau
Member
Carreau commented Jul 25, 2016

Ok, codecov is annoying as failing PRs, so merging this.

@Carreau Carreau merged commit c44d5f5 into ipython:master Jul 25, 2016

3 checks passed

codecov/patch 0.00% of diff hit (target 0.00%)
Details
codecov/project 73.23% (-1.02%) compared to f4d0d99
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment