PyPy-ready IPython.lib.pretty, new tox.ini and consistent dict/mapping proxies pretty printing #9827
Conversation
+3 tests passing
Also fixed the _dict_pprinter_factory indentation step
- Add tests for dict proxies (instances of types.DictProxyType)
- Uses the "dict_proxy({...})" pattern for representation, as happens
in CPython 2.7 with types.DictProxyType.__repr__
- Used ctypes.pythonapi.PyDictProxy_New to instantiate dict proxies
inside the tests
- Only for CPython 2.7: in PyPy the types.DictProxyType is dict, and
in CPython 3 there's no such type, just the new
types.MappingProxyType in CPython 3.3+
The test_pretty.test_dictproxy now is properly skipped on PyPy
In PyPy there's no __self__ attribute for super(.) objects. As objects always have a __repr__, the found alternative was to use its curried argument. Previously, only the class name was verified as part of the result, now the tests include a regex.
+1 test passing in PyPy
|
Done. If required, I can rebase/stash/split the commits in this PR while it's just an experimental branch (perhaps to have a separate PR for the MappingProxyType update, or to join the For older PyPy (Python 2.7) versions (e.g. v4.0.1), this PR has more failures, including some in As of today, the last stable PyPy versions are v2.6.1, v4.0.1 and v5.3.1. The last PyPy3 versions are v2.4.0 (a Python 3.2 that allows u-prefixed unicode strings) and v5.2.0-alpha1 (Python 3.3), but this PR is only about PyPy, not PyPy3. |
|
Thanks a lot for that ! I'm assigning myself to look at it this week ! 🎊 |
|
That's great, thanks @danilobellini! |
| @@ -292,6 +292,7 @@ def execfile(fname, glob=None, loc=None, compiler=None): | |||
|
|
|||
|
|
|||
| PY2 = not PY3 | |||
| PYPY = any(k.startswith("pypy") for k in dir(sys)) | |||
There was a problem hiding this comment.
I think platform.python_implementation() is a nicer place to look for PyPy
No need to do that, the only thing we tend to avoid is to merge master into the pull requests as we have some tooling that assume merge commits are merged PR to autolist list of PRs.
No problem, many tests are doctest, I think we could just skip them.
Good point, once the PYPY variable is moved I"m og merging this in, and we can refine in subsequent tests ! Thanks a lot ! |
|
Thanks a lot! |
|
You're welcome =) The test_pretty.py is passing in PyPy 5.3.1, but in PyPy 4.0.1 there are 2 failures. I was trying to fix these, where to test in a specific PyPy version here I was using a prepared docker image: https://hub.docker.com/r/library/pypy/ One of such failures is easy to fix (the |
types.MappingProxyTypepretty printer + tests)dictrepresentation formatter/printer by thetypes.DictProxyTypeone)tox.ini, easier to test multiple environments (e.g.tox -e py36,pypy -- lib utilscall "iptest lib utils" in CPython 3.6 and PyPy) including matplotlib (but in PyPy).travis.ymlto test with PyPy (still known to fail, so it's inallow_failures)test_pretty.pytests passes in every environment (including PyPy)super(...)objects in PyPy. Previously, it was like:"<unknown type>". This can be further enhanced to get the definition name, as it's stored at least in the object__repr__IPython.lib.pretty._dict_pprinter_factoryindentation size to be equal to the prefix sizetypes.DictProxyTypewith an extractypes-based test to instantiate it directly with the Python API. The pretty printing uses the format used by dict proxiestypes.DictProxyType.__repr__in CPython 2.7, printing it as"dict_proxy({...})", but with the sorting and line-breaking pretty printing features.