New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'Linux' (dark bg) colours for Windows #9838

Merged
merged 1 commit into from Aug 4, 2016

Conversation

Projects
None yet
2 participants
@takluyver
Member

takluyver commented Aug 4, 2016

This puts the colours in inspect output and tracebacks back to what they were in IPython 4.x, but leaves the prompt colouring as in 5.0. I tried changing the colour scheme to 'Linux' entirely for Windows, but that selects Monokai as the theme for prompt_toolkit, which looks pretty horrible in 16 colours (at least to my eyes).

This is admittedly a hack, but hopefully our legacy colour system is on the way out anyway.

Closes gh-9723

Use 'Linux' (dark bg) colours for Windows
This puts the colours in inspect output and tracebacks back to what
they were in IPython 4.x, but leaves the prompt colouring as in 5.0.
I tried changing the colour scheme to 'Linux' entirely for Windows,
but that selects Monokai as the theme for prompt_toolkit, which looks
pretty horrible in 16 colours (at least to my eyes).

This is admittedly a hack, but hopefully our legacy colour system is
on the way out anyway.

Closes gh-9723

@takluyver takluyver added this to the 5.1 milestone Aug 4, 2016

@Carreau Carreau merged commit 345bf7d into ipython:master Aug 4, 2016

3 checks passed

codecov/patch 50.00% of diff hit (target 0.00%)
Details
codecov/project 73.56% (+<.01%) compared to 6a38355
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment