Allow to pass a pygments class to highlighting_style. #9848

Merged
merged 1 commit into from Aug 23, 2016

Projects

None yet

3 participants

@memeplex
Contributor
memeplex commented Aug 8, 2016

Fixes #9749.

@memeplex memeplex Allow to pass a pygments class to highlighting_style.
Fixes #9749.
8e65bf0
@takluyver takluyver added this to the 5.2 milestone Aug 8, 2016
@takluyver
Member

Thanks. This looks OK to me.

@takluyver
Member

Not merging yet, because we're trying to get 5.1 out, and this is a new feature. I've milestoned it for 5.2.

@Carreau
Member
Carreau commented Aug 14, 2016

@takluyver do you feel comfortable starting to merge the 5.2's ? @memeplex do you want to add a line in docs/source/whatsnew ?

@takluyver
Member

I think it's fine to start merging 5.2 things. Yes, @memeplex please do drop a file in docs/source/whatsnew/pr about the change.

@Carreau Carreau merged commit c24d7bb into ipython:master Aug 23, 2016

3 checks passed

codecov/patch 63.63% of diff hit (target 0.00%)
Details
codecov/project 73.56% (-0.01%) compared to 345bf7d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau
Member
Carreau commented Aug 24, 2016

Added #9901 to remind us to drop a note in what's new.

I'm also tempted to bump that as 6.0.

@memeplex
Contributor

Sorry I forgot about the note. I'm submitting a PR tomorrow.

@takluyver
Member

This feels like something that can be in a 5.x release.

@Carreau Carreau added a commit to Carreau/ipython that referenced this pull request Sep 18, 2016
@Carreau Carreau Backport PR #9848: Allow to pass a pygments class to highlighting_style. 39b4a6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment