-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass a pygments class to highlighting_style. #9848
Conversation
Thanks. This looks OK to me. |
Not merging yet, because we're trying to get 5.1 out, and this is a new feature. I've milestoned it for 5.2. |
@takluyver do you feel comfortable starting to merge the 5.2's ? @memeplex do you want to add a line in docs/source/whatsnew ? |
I think it's fine to start merging 5.2 things. Yes, @memeplex please do drop a file in docs/source/whatsnew/pr about the change. |
Added #9901 to remind us to drop a note in what's new. I'm also tempted to bump that as 6.0. |
Sorry I forgot about the note. I'm submitting a PR tomorrow. |
This feels like something that can be in a 5.x release. |
…ing_style. Fixes ipython#9749.
I have converted my prompt toolkit theme into a template and generated all base16 themes from it. I'm now in the process of registering my repo as an "official" base16 source. https://github.com/memeplex/base16-prompt-toolkit So now there is the full base16 suite to choose from! Do you want me to add an entry to the wiki or an example to the docs? |
Cool, thanks! I think it would slot into the docs neatly as a subheading in this section: |
@memeplex did you published in on PyPI ? |
No, I didn't. I will try to do it during the next few days.
|
Sweet, once you do it we can add a recipe to the docs ! |
Fixes #9749.