New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass a pygments class to highlighting_style. #9848

Merged
merged 1 commit into from Aug 23, 2016

Conversation

Projects
None yet
3 participants
@memeplex
Contributor

memeplex commented Aug 8, 2016

Fixes #9749.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Aug 8, 2016

Member

Thanks. This looks OK to me.

Member

takluyver commented Aug 8, 2016

Thanks. This looks OK to me.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Aug 8, 2016

Member

Not merging yet, because we're trying to get 5.1 out, and this is a new feature. I've milestoned it for 5.2.

Member

takluyver commented Aug 8, 2016

Not merging yet, because we're trying to get 5.1 out, and this is a new feature. I've milestoned it for 5.2.

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Aug 14, 2016

Member

@takluyver do you feel comfortable starting to merge the 5.2's ? @memeplex do you want to add a line in docs/source/whatsnew ?

Member

Carreau commented Aug 14, 2016

@takluyver do you feel comfortable starting to merge the 5.2's ? @memeplex do you want to add a line in docs/source/whatsnew ?

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Aug 15, 2016

Member

I think it's fine to start merging 5.2 things. Yes, @memeplex please do drop a file in docs/source/whatsnew/pr about the change.

Member

takluyver commented Aug 15, 2016

I think it's fine to start merging 5.2 things. Yes, @memeplex please do drop a file in docs/source/whatsnew/pr about the change.

@Carreau Carreau merged commit c24d7bb into ipython:master Aug 23, 2016

3 checks passed

codecov/patch 63.63% of diff hit (target 0.00%)
Details
codecov/project 73.56% (-0.01%) compared to 345bf7d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Aug 24, 2016

Member

Added #9901 to remind us to drop a note in what's new.

I'm also tempted to bump that as 6.0.

Member

Carreau commented Aug 24, 2016

Added #9901 to remind us to drop a note in what's new.

I'm also tempted to bump that as 6.0.

@memeplex

This comment has been minimized.

Show comment
Hide comment
@memeplex

memeplex Aug 24, 2016

Contributor

Sorry I forgot about the note. I'm submitting a PR tomorrow.

Contributor

memeplex commented Aug 24, 2016

Sorry I forgot about the note. I'm submitting a PR tomorrow.

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Aug 24, 2016

Member

This feels like something that can be in a 5.x release.

Member

takluyver commented Aug 24, 2016

This feels like something that can be in a 5.x release.

Carreau added a commit to Carreau/ipython that referenced this pull request Sep 18, 2016

@memeplex

This comment has been minimized.

Show comment
Hide comment
@memeplex

memeplex Feb 26, 2017

Contributor

I have converted my prompt toolkit theme into a template and generated all base16 themes from it. I'm now in the process of registering my repo as an "official" base16 source.

https://github.com/memeplex/base16-prompt-toolkit

So now there is the full base16 suite to choose from! Do you want me to add an entry to the wiki or an example to the docs?

Contributor

memeplex commented Feb 26, 2017

I have converted my prompt toolkit theme into a template and generated all base16 themes from it. I'm now in the process of registering my repo as an "official" base16 source.

https://github.com/memeplex/base16-prompt-toolkit

So now there is the full base16 suite to choose from! Do you want me to add an entry to the wiki or an example to the docs?

@takluyver

This comment has been minimized.

Show comment
Hide comment
@takluyver

takluyver Feb 27, 2017

Member

Cool, thanks! I think it would slot into the docs neatly as a subheading in this section:
http://ipython.readthedocs.io/en/stable/config/details.html#terminal-colors

Member

takluyver commented Feb 27, 2017

Cool, thanks! I think it would slot into the docs neatly as a subheading in this section:
http://ipython.readthedocs.io/en/stable/config/details.html#terminal-colors

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Feb 27, 2017

Member

@memeplex did you published in on PyPI ?

Member

Carreau commented Feb 27, 2017

@memeplex did you published in on PyPI ?

@memeplex

This comment has been minimized.

Show comment
Hide comment
@memeplex

memeplex Feb 27, 2017

Contributor
Contributor

memeplex commented Feb 27, 2017

@Carreau

This comment has been minimized.

Show comment
Hide comment
@Carreau

Carreau Feb 27, 2017

Member

No, I didn't. I will try to do it during the next few days.

Sweet, once you do it we can add a recipe to the docs !

Member

Carreau commented Feb 27, 2017

No, I didn't. I will try to do it during the next few days.

Sweet, once you do it we can add a recipe to the docs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment