run CFRunLoopRun if NSApp:run finishes on its own #9854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems to happen when the last Window is closed, but the eventloop needs to run a little longer in order to finish closing the Window
|
I obviously can't test this; do you want to get other affected people to try it before we merge? If you're happy, feel free to merge it yourself. |
|
@minrk and @takluyver PR works on my OS X configuration to close last figure window. |
|
I could reliably reproduce the bug, and this fixes it for me. @willingc's corroboration seems like enough to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to happen when the last Window is closed, but the eventloop needs to run a little longer in order to finish closing the Window.
closes #9734