Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run CFRunLoopRun if NSApp:run finishes on its own #9854

Merged
merged 1 commit into from Aug 10, 2016

Conversation

minrk
Copy link
Member

@minrk minrk commented Aug 10, 2016

This seems to happen when the last Window is closed, but the eventloop needs to run a little longer in order to finish closing the Window.

closes #9734

this seems to happen when the last Window is closed,
but the eventloop needs to run a little longer in order to finish closing the Window
@takluyver
Copy link
Member

takluyver commented Aug 10, 2016

I obviously can't test this; do you want to get other affected people to try it before we merge? If you're happy, feel free to merge it yourself.

@takluyver takluyver added this to the 5.1 milestone Aug 10, 2016
@willingc
Copy link
Member

willingc commented Aug 10, 2016

@minrk and @takluyver PR works on my OS X configuration to close last figure window.

@minrk
Copy link
Member Author

minrk commented Aug 10, 2016

I could reliably reproduce the bug, and this fixes it for me. @willingc's corroboration seems like enough to merge.

@takluyver takluyver merged commit a1be241 into ipython:master Aug 10, 2016
3 checks passed
@minrk minrk deleted the osx-inputhook-last-window branch Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot close last figure window
3 participants