run CFRunLoopRun if NSApp:run finishes on its own #9854

Merged
merged 1 commit into from Aug 10, 2016

Projects

None yet

3 participants

@minrk
Member
minrk commented Aug 10, 2016

This seems to happen when the last Window is closed, but the eventloop needs to run a little longer in order to finish closing the Window.

closes #9734

@minrk minrk run CFRunLoopRun if NSApp:run finishes on its own
this seems to happen when the last Window is closed,
but the eventloop needs to run a little longer in order to finish closing the Window
e975cd7
@takluyver
Member

I obviously can't test this; do you want to get other affected people to try it before we merge? If you're happy, feel free to merge it yourself.

@takluyver takluyver added this to the 5.1 milestone Aug 10, 2016
@willingc
Member

@minrk and @takluyver PR works on my OS X configuration to close last figure window.

@minrk
Member
minrk commented Aug 10, 2016

I could reliably reproduce the bug, and this fixes it for me. @willingc's corroboration seems like enough to merge.

@takluyver takluyver merged commit a1be241 into ipython:master Aug 10, 2016

3 checks passed

codecov/patch Coverage not affected when comparing f03536e...e975cd7
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +26.43% compared to f03536e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@minrk minrk deleted the minrk:osx-inputhook-last-window branch Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment