Deprecate -e flag for %notebook magic #9872

Merged
merged 2 commits into from Aug 15, 2016

Projects

None yet

2 participants

@takluyver
Member

Maybe the magic did something else in the past? Now the -e or --export flag is just confusing.

I've left it in place so it will still work, but have no effect.

@takluyver takluyver Deprecate -e flag for %notebook magic
Maybe the magic did something else in the past? Now the flag is just
confusing.

I've left it in place so it will still work, but have no effect.
6fabe0b
@takluyver takluyver added this to the 5.2 milestone Aug 14, 2016
@minrk minrk and 1 other commented on an outdated diff Aug 14, 2016
IPython/core/magics/basic.py
@@ -563,22 +560,25 @@ def notebook(self, s):
"""Export and convert IPython notebooks.
This function can export the current IPython history to a notebook file.
- For example, to export the history to "foo.ipynb" do "%notebook -e foo.ipynb".
- To export the history to "foo.py" do "%notebook -e foo.py".
+ For example, to export the history to "foo.ipynb" do "%notebook foo.ipynb".
+ To export the history to "foo.py" do "%notebook foo.py".
@minrk
minrk Aug 14, 2016 Member

I think %notebook foo.py won't work, only notebooks can be written.

@takluyver
takluyver Aug 15, 2016 Member

Good point, removed

@takluyver takluyver Remove mention of exporting to .py file with %notebook
85dcb36
@minrk minrk merged commit ba368a2 into ipython:master Aug 15, 2016

3 checks passed

codecov/patch 90.00% of diff hit (target 0.00%)
Details
codecov/project Absolute coverage decreased by -0.45% but relative coverage increased by +16.43% compared to de84d5a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Carreau Carreau added a commit to Carreau/ipython that referenced this pull request Sep 18, 2016
@Carreau Carreau Backport PR #9872: Deprecate -e flag for %notebook magic
Maybe the magic did something else in the past? Now the `-e` or `--export` flag is just confusing.

I've left it in place so it will still work, but have no effect.
914d815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment