Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate -e flag for %notebook magic #9872

Merged
merged 2 commits into from Aug 15, 2016

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Aug 14, 2016

Maybe the magic did something else in the past? Now the -e or --export flag is just confusing.

I've left it in place so it will still work, but have no effect.

Maybe the magic did something else in the past? Now the flag is just
confusing.

I've left it in place so it will still work, but have no effect.
@takluyver takluyver added this to the 5.2 milestone Aug 14, 2016
For example, to export the history to "foo.ipynb" do "%notebook -e foo.ipynb".
To export the history to "foo.py" do "%notebook -e foo.py".
For example, to export the history to "foo.ipynb" do "%notebook foo.ipynb".
To export the history to "foo.py" do "%notebook foo.py".

This comment has been minimized.

@minrk

minrk Aug 14, 2016
Member

I think %notebook foo.py won't work, only notebooks can be written.

This comment has been minimized.

@takluyver

takluyver Aug 15, 2016
Author Member

Good point, removed

@minrk minrk merged commit ba368a2 into ipython:master Aug 15, 2016
3 checks passed
3 checks passed
codecov/patch 90.00% of diff hit (target 0.00%)
Details
codecov/project Absolute coverage decreased by -0.45% but relative coverage increased by +16.43% compared to de84d5a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Carreau added a commit to Carreau/ipython that referenced this pull request Sep 18, 2016
Maybe the magic did something else in the past? Now the `-e` or `--export` flag is just confusing.

I've left it in place so it will still work, but have no effect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants