Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rounded corners on widgets #1035

Closed
ellisonbg opened this issue Jan 6, 2017 · 9 comments · Fixed by #1036
Closed

Rounded corners on widgets #1035

ellisonbg opened this issue Jan 6, 2017 · 9 comments · Fixed by #1036
Labels
bug resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@ellisonbg
Copy link
Member

Saw this widget has rounded corners...

screen shot 2017-01-06 at 11 54 01 am

@SylvainCorlay

@ellisonbg ellisonbg added the bug label Jan 6, 2017
@SylvainCorlay
Copy link
Member

Indeed, the nbviewer rendering should help with the UX / UI / design review.

@ellisonbg
Copy link
Member Author

ellisonbg commented Jan 6, 2017 via email

@SylvainCorlay
Copy link
Member

SylvainCorlay commented Jan 6, 2017

@jasongrout
Copy link
Member

Saw this widget has rounded corners...

That's the native browser select box - we may not be able to style it very well or consistently...

@ellisonbg
Copy link
Member Author

ellisonbg commented Jan 7, 2017 via email

@SylvainCorlay
Copy link
Member

Jupyterlab removes the border from select boxes and styles the enclosing div as far as I can recall.

@blink1073
Copy link
Contributor

Yep, in the dialog CSS we have select and selectWrapper styles (on my phone).

@SylvainCorlay
Copy link
Member

^ Btw, these seem to be missing for the cell-type select input.

@ellisonbg
Copy link
Member Author

ellisonbg commented Jan 7, 2017 via email

@jasongrout jasongrout modified the milestone: 6.0 Mar 1, 2017
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants