Skip to content

tx-signer: Ledger support #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tony-iqlusion opened this issue Jul 2, 2020 · 3 comments
Closed

tx-signer: Ledger support #105

tony-iqlusion opened this issue Jul 2, 2020 · 3 comments
Labels
enhancement New feature or request tx-signer Transaction Signer-related issues

Comments

@tony-iqlusion
Copy link
Member

This is a tracking issue for supporting account keys held by a Ledger device.

Since Ledger apps which sign Tendermint transactions today (e.g. the Cosmos App) typically require user interaction, and KMS transaction signing is specifically intended to be used for online, non-interactive signing, the first step towards adding support for this feature would likely involve adding account key support to the Ledger Tendermint Validator App which provides non-interactive account key support.

@tony-iqlusion tony-iqlusion added enhancement New feature or request tx-signer Transaction Signer-related issues labels Jul 2, 2020
@assafmo
Copy link

assafmo commented Jul 14, 2020

How will that work? How can you go around the physical requirement of a user clicking on the device?

@tony-iqlusion
Copy link
Member Author

The Ledger Tendermint Validator App already performs non-interactive Ed25519 signing for consensus keys.

It could potentially be extended to also support non-interactive ECDSA/secp256k1 signing for account keys.

Granted in either case, boot is attended and the user must enter their pin before launching the app.

@tony-iqlusion
Copy link
Member Author

tx-signer support was removed in #764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tx-signer Transaction Signer-related issues
Projects
None yet
Development

No branches or pull requests

2 participants