Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support both the Tendermint legacy and v0.33 secret connection handshake #58

Merged
merged 6 commits into from Jun 7, 2020

Conversation

zmanian
Copy link
Contributor

@zmanian zmanian commented Jun 6, 2020

This pull requests adds support for both the Tendermint legacy secret connection handshake that has a malleability vulnerability and the Tendermint v0.33 handshake that uses a transcript hash to defeat malleability.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2020

Codecov Report

Merging #58 into develop will increase coverage by 0.10%.
The diff coverage is 46.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #58      +/-   ##
===========================================
+ Coverage    28.74%   28.85%   +0.10%     
===========================================
  Files           50       50              
  Lines         1816     1837      +21     
===========================================
+ Hits           522      530       +8     
- Misses        1294     1307      +13     
Impacted Files Coverage Δ
src/config/validator.rs 0.00% <0.00%> (ø)
src/connection/tcp.rs 0.00% <0.00%> (ø)
src/session.rs 0.00% <0.00%> (ø)
src/connection/secret_connection.rs 71.19% <76.47%> (-0.32%) ⬇️
tests/integration.rs 88.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9448f...9507aa5. Read the comment docs.

src/config/validator.rs Outdated Show resolved Hide resolved
@zmanian zmanian merged commit 45a7370 into develop Jun 7, 2020
10 checks passed
@tony-iqlusion tony-iqlusion deleted the zaki-support-new-handshake branch Jun 7, 2020
@tony-iqlusion tony-iqlusion mentioned this pull request Jun 7, 2020
@tony-iqlusion tony-iqlusion mentioned this pull request Jun 8, 2020
This was referenced Jun 23, 2020
@tony-iqlusion tony-iqlusion mentioned this pull request Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants