Support both the Tendermint legacy and v0.33 secret connection handshake#58
Merged
Support both the Tendermint legacy and v0.33 secret connection handshake#58
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #58 +/- ##
===========================================
+ Coverage 28.74% 28.85% +0.10%
===========================================
Files 50 50
Lines 1816 1837 +21
===========================================
+ Hits 522 530 +8
- Misses 1294 1307 +13
Continue to review full report at Codecov.
|
…mkms into zaki-support-new-handshake
tony-iqlusion
approved these changes
Jun 7, 2020
Closed
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for both the Tendermint legacy secret connection handshake that has a malleability vulnerability and the Tendermint v0.33 handshake that uses a transcript hash to defeat malleability.