ENH: Add windows support #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le on local windows
rmcar17
force-pushed
the
windows-support
branch
from
01170cf to
52ae293
Compare
rmcar17
force-pushed
the
windows-support
branch
from
79abb38 to
8e99db3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43
Adds windows support to piqtree including in release workflow.
Limitation with relying with error handling on IQ-TREE side - errors which would be thrown as an IqTreeError on mac/linux instead cause an ungraceful exit. See skipped tests for examples. Could potentially handle common cases on Python side, though preference would be handling on IQ-TREE side in the long-term so new errors can be freely added/removed without duplication on Python side.
Phew!