From ca4bd7d6805e4df98229d0b193e8023020c69c08 Mon Sep 17 00:00:00 2001 From: Robert McArthur Date: Sat, 19 Jul 2025 15:51:47 +1000 Subject: [PATCH 1/2] MAINT: Correct changleog --- changelog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index 81b44ce0..88d7c3c2 100644 --- a/changelog.md +++ b/changelog.md @@ -9,7 +9,7 @@ ## BUG -- Pin build dependencies to workaround bug an upstream bug. +- Pin build dependencies for reproducible builds and use new delvewheel `get_all_needed` API. ## DOC From 2596cd12d7c7b62a18eae1fcdaa3e1a3804d8db5 Mon Sep 17 00:00:00 2001 From: Robert McArthur Date: Thu, 31 Jul 2025 13:48:50 +1000 Subject: [PATCH 2/2] TST: Improve branch length testing in preparation for TreeNode deprecation --- tests/test_iqtree/test_build_tree.py | 3 +-- tests/test_iqtree/test_protein_build_tree.py | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/test_iqtree/test_build_tree.py b/tests/test_iqtree/test_build_tree.py index 3983227c..9ff57102 100644 --- a/tests/test_iqtree/test_build_tree.py +++ b/tests/test_iqtree/test_build_tree.py @@ -30,11 +30,10 @@ def check_build_tree_model( expected = make_tree("(Human,Chimpanzee,(SpermWhale,HumpbackW));") got = piqtree.build_tree(aln, str(model) if coerce_str else model) - # Check topology assert expected.same_topology(got.unrooted()) # Check if branch lengths exist - assert all("length" in v.params for v in got.get_edge_vector()) + assert all(v.length is not None for v in got.get_edge_vector(include_root=False)) def check_build_tree( diff --git a/tests/test_iqtree/test_protein_build_tree.py b/tests/test_iqtree/test_protein_build_tree.py index d74c509a..17b009ca 100644 --- a/tests/test_iqtree/test_protein_build_tree.py +++ b/tests/test_iqtree/test_protein_build_tree.py @@ -18,9 +18,8 @@ def check_build_tree_model( coerce_str: bool = False, ) -> None: got = piqtree.build_tree(aln, str(model) if coerce_str else model, rand_seed=1) - # Check if all branch lengths exist - assert all("length" in v.params for v in got.get_edge_vector()) + assert all(v.length is not None for v in got.get_edge_vector(include_root=False)) def check_build_tree(