Skip to content
This repository was archived by the owner on May 2, 2025. It is now read-only.

[developer] Getting Started with Typescript - first pass #96

Merged
merged 4 commits into from
Dec 28, 2023
Merged

[developer] Getting Started with Typescript - first pass #96

merged 4 commits into from
Dec 28, 2023

Conversation

@anselm
Copy link
Contributor

@anselm anselm commented Dec 27, 2023

No description provided.

@anselm anselm changed the title note re segue typescript first pass Dec 27, 2023
HexaField
HexaField suggested changes Dec 27, 2023
View reviewed changes
@anselm
escaping brackets?
2e8317f
@anselm
docusaurus disallows <> without escaping except in code blocks, also …
ee6a18b 
…{ something } is treated as some kind of variable and should not be used otherwise
@HexaField HexaField merged commit 43f8f7d into main Dec 28, 2023
@HexaField HexaField deleted the tut-typescript branch December 28, 2023 07:12
@heysokam heysokam changed the title typescript first pass [developer] Getting Started with Typescript - first pass Dec 28, 2023
@heysokam heysokam restored the tut-typescript branch December 28, 2023 19:13
@heysokam
Copy link
Contributor

heysokam commented Dec 28, 2023 •
edited
Loading

This PR breaks the markdown styling guides defined at:
https://github.com/EtherealEngine/etherealengine-docs/?tab=readme-ov-file#contributing-guidelines-documentation-repository
There are some guidelines that I've been following that I was going to review and also annotate in the guidelines today (they are not there listed yet), but didn't have the time to comment on before this merge.

I will restore the branch and open a new PR with the fixes.

@heysokam heysokam added documentation Improvements or additions to documentation developer Anything related to the Developers section of the documentation website labels Dec 28, 2023
@HexaField
Copy link
Contributor

This PR breaks the markdown styling guides defined at:
https://github.com/EtherealEngine/etherealengine-docs/?tab=readme-ov-file#contributing-guidelines-documentation-repository
There are some guidelines that I've been following that I was going to review and also annotate in the guidelines today (they are not there listed yet), but didn't have the time to comment on before this merge.

I will restore the branch and open a new PR with the fixes.

I merged this in as our CICD had broken and this was passing.

@HexaField HexaField deleted the tut-typescript branch December 28, 2023 20:59
@heysokam heysokam mentioned this pull request Dec 28, 2023
Draft
16 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@HexaField HexaField HexaField requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anselm anselm

@heysokam heysokam

Labels

developer Anything related to the Developers section of the documentation website documentation Improvements or additions to documentation verified-contributor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anselm @heysokam @HexaField