This repository has been archived by the owner. It is now read-only.

Patches for linux build #10

Open
wants to merge 48 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@joequant

joequant commented Apr 30, 2017

“The Schleswig-Holstein question is so complicated, only three men in Europe have ever understood it. One was Prince Albert, who is dead. The second was a German professor who became mad. I am the third and I have forgotten all about it.”

Here are the changes that I made to get IRAF to build on linux with host libraries. There is a README.md. The build.sh runs the system.

I remember that I had to do crazy things with pointers to get it to work...

@joequant joequant changed the title from Linux build to Patches for linux build Apr 30, 2017

@iraf

This comment has been minimized.

Show comment
Hide comment
@iraf

iraf Apr 30, 2017

Owner

As an omnibus "I had to do some crazy things but I forget why" I can tell you now this PR isn't going anywhere. There are clear errors that break the system (e.g. the iraf setjmp.h cannot be replaced by the system <setjmp.h>, the distributed readline has a change required by the CL, etc) and other that appear linux-specific. Please resubmit as more-targeted PRs that address specific issues, clearly explain what is being addressed, and ideally show they work on all 4 supported systems (macosx/macintel/linux/linux64).

Owner

iraf commented Apr 30, 2017

As an omnibus "I had to do some crazy things but I forget why" I can tell you now this PR isn't going anywhere. There are clear errors that break the system (e.g. the iraf setjmp.h cannot be replaced by the system <setjmp.h>, the distributed readline has a change required by the CL, etc) and other that appear linux-specific. Please resubmit as more-targeted PRs that address specific issues, clearly explain what is being addressed, and ideally show they work on all 4 supported systems (macosx/macintel/linux/linux64).

@steelewool

This comment has been minimized.

Show comment
Hide comment
@steelewool

steelewool Apr 30, 2017

If @joequant pull request is being rejected is there some effort by @iraf to fix the broken linux64 build. The documentation states: ./install; make linux64; make sysgen; should build and instead has errors. @zcsteele and I can both confirm that the 2.16.1 version doesn't build.

steelewool commented Apr 30, 2017

If @joequant pull request is being rejected is there some effort by @iraf to fix the broken linux64 build. The documentation states: ./install; make linux64; make sysgen; should build and instead has errors. @zcsteele and I can both confirm that the 2.16.1 version doesn't build.

@iraf

This comment has been minimized.

Show comment
Hide comment
@iraf

iraf Apr 30, 2017

Owner
Owner

iraf commented Apr 30, 2017

@joequant

This comment has been minimized.

Show comment
Hide comment
@joequant

joequant Apr 30, 2017

Didn't expect the pull request to be accepted as is, but I've submitted it so that other people that want to clean it up have access to it. The version in my source tree hasn't been updated to compile with the main branch but this does.

The main reason that I submitted the patch is that there are some seriously weird pointer arithmetic stuff that needs to be done to make this work, and while I forgot what I needed to do, they are in the patch somewhere.

joequant commented Apr 30, 2017

Didn't expect the pull request to be accepted as is, but I've submitted it so that other people that want to clean it up have access to it. The version in my source tree hasn't been updated to compile with the main branch but this does.

The main reason that I submitted the patch is that there are some seriously weird pointer arithmetic stuff that needs to be done to make this work, and while I forgot what I needed to do, they are in the patch somewhere.

@joequant

This comment has been minimized.

Show comment
Hide comment
@joequant

joequant Apr 30, 2017

Why can't the IRAF setjmp be replaced by the system setjmp, and what are the patches in the system readline that are necessary?

joequant commented Apr 30, 2017

Why can't the IRAF setjmp be replaced by the system setjmp, and what are the patches in the system readline that are necessary?

@iraf

This comment has been minimized.

Show comment
Hide comment
@iraf

iraf Apr 30, 2017

Owner
Owner

iraf commented Apr 30, 2017

@olebole

Maybe you create an individual pull request for this patch?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.