This repository has been archived by the owner. It is now read-only.

Cleanup generated files #25

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@olebole
Contributor

olebole commented May 2, 2017

This PR cleans up files that are generated during the build and therefore not needed in the git repository.

@iraf

This comment has been minimized.

Show comment
Hide comment
@iraf

iraf May 2, 2017

Owner
Owner

iraf commented May 2, 2017

@olebole

This comment has been minimized.

Show comment
Hide comment
@olebole

olebole May 2, 2017

Contributor

This is how far I came before the compilation stopped because of the missing libVO.a. There may be more. However, if the current list has no errors (even if incomplete), it would be nice to merge. This would make the next PR to the same topic smaller.
The same applies to the other cleanup PRs. If I find new files, I will append them to the according PR if it is not merged; otherwise I will just open a new one (if there is a significant number).
BTW, if you know more files yourself, you could add them to the PR as well, since maintainer-editing is switched on. There is no need to wait for me :-)

Contributor

olebole commented May 2, 2017

This is how far I came before the compilation stopped because of the missing libVO.a. There may be more. However, if the current list has no errors (even if incomplete), it would be nice to merge. This would make the next PR to the same topic smaller.
The same applies to the other cleanup PRs. If I find new files, I will append them to the according PR if it is not merged; otherwise I will just open a new one (if there is a significant number).
BTW, if you know more files yourself, you could add them to the PR as well, since maintainer-editing is switched on. There is no need to wait for me :-)

@iraf

This comment has been minimized.

Show comment
Hide comment
@iraf

iraf May 3, 2017

Owner
Owner

iraf commented May 3, 2017

@olebole

This comment has been minimized.

Show comment
Hide comment
@olebole

olebole May 3, 2017

Contributor

Generally, please comment the pull requests on their own place, and do not mix everything up in a single statement. This makes it difficult to follow the discussion on a longer term.

I scoff because things like the vops files are 'generated' only of they don't exist, so it's a metaphysical question of whether they should be removed from a source build (and it's irritating to have multiple PRs for these files as you discover them when there is clearly a way to build a complete list should that be the way to go (I'd say not, BTW)).

The sys/vops/ak/ files are always generated -- the reason I discovered this was that some of them actually changed during the build. And it is not just metaphysical, but a question of a clean code and development: if one wants to fix something there, one should not fix it in sys/vops/ak/ but in sys/vops/achtgen/ and other places. So, there is no reason to keep these files.

For the other comments, I will answer in the revelant PRs (and cite your statement there for completeness).

Contributor

olebole commented May 3, 2017

Generally, please comment the pull requests on their own place, and do not mix everything up in a single statement. This makes it difficult to follow the discussion on a longer term.

I scoff because things like the vops files are 'generated' only of they don't exist, so it's a metaphysical question of whether they should be removed from a source build (and it's irritating to have multiple PRs for these files as you discover them when there is clearly a way to build a complete list should that be the way to go (I'd say not, BTW)).

The sys/vops/ak/ files are always generated -- the reason I discovered this was that some of them actually changed during the build. And it is not just metaphysical, but a question of a clean code and development: if one wants to fix something there, one should not fix it in sys/vops/ak/ but in sys/vops/achtgen/ and other places. So, there is no reason to keep these files.

For the other comments, I will answer in the revelant PRs (and cite your statement there for completeness).

@olebole

This comment has been minimized.

Show comment
Hide comment
@olebole

olebole May 3, 2017

Contributor

PRs that delete these files miss the bigger picture about the 'build problems' covered in other issues, i.e. that a "make src ; make sysgen" should produce a source tree free of these generated files (basically what the original 'git clone' provides) and then build/regenerate cleanly.

Just to make an addition here: Currently, "make src" will generate a tree that is different from the original one, since it takes the generated files sys/vops/ak/acht*.x and not the original ones (which were overwritten). So, currently the process is already broken. Completely removing these files from the source will partially fix it; the other part will be to add these files to the files to be cleaned. The same is true, BTW, for the files that get /iraf/iraf/ replaced by the current install path.

Contributor

olebole commented May 3, 2017

PRs that delete these files miss the bigger picture about the 'build problems' covered in other issues, i.e. that a "make src ; make sysgen" should produce a source tree free of these generated files (basically what the original 'git clone' provides) and then build/regenerate cleanly.

Just to make an addition here: Currently, "make src" will generate a tree that is different from the original one, since it takes the generated files sys/vops/ak/acht*.x and not the original ones (which were overwritten). So, currently the process is already broken. Completely removing these files from the source will partially fix it; the other part will be to add these files to the files to be cleaned. The same is true, BTW, for the files that get /iraf/iraf/ replaced by the current install path.

@RobSteele49

This comment has been minimized.

Show comment
Hide comment
@RobSteele49

RobSteele49 May 5, 2017

Just to chime in, since I'm testing olebole's code - things look good to me relative to the PR.

RobSteele49 commented May 5, 2017

Just to chime in, since I'm testing olebole's code - things look good to me relative to the PR.

@olebole

This comment has been minimized.

Show comment
Hide comment
@olebole

olebole May 8, 2017

Contributor

I left out the files in sys/vops/ak here: there are many more occurances where files are (or can be) regenerated with generic. They are subject of a different discussion and therefore of another (to be written) PR.

Contributor

olebole commented May 8, 2017

I left out the files in sys/vops/ak here: there are many more occurances where files are (or can be) regenerated with generic. They are subject of a different discussion and therefore of another (to be written) PR.

Remove more intermediate files
They are not all generated automatically, but also by some manual steps
like "etags". However, they are simply regenerated, and should so since they
are out of date anyway.
@olebole

This comment has been minimized.

Show comment
Hide comment
@olebole

olebole Sep 10, 2017

Contributor

@iraf

Will there be a separate PR with another list of all the generated files not listed here?

I think this one is complete, except for the discussion about sys/vops/ak/acht*.x (see above). A make sysgen ; make src ends up with the same files (except #96).

So, it can be merged from my point of view.

Contributor

olebole commented Sep 10, 2017

@iraf

Will there be a separate PR with another list of all the generated files not listed here?

I think this one is complete, except for the discussion about sys/vops/ak/acht*.x (see above). A make sysgen ; make src ends up with the same files (except #96).

So, it can be merged from my point of view.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.