Use POST requests when contacting the telegram api server. #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst a GET request according to the specs may have an unlimited number of characters, in practice it appears that different versions of PHP and even webbrowsers do have a limit.
http://stackoverflow.com/questions/3091485/what-is-the-limit-on-querystring-get-url-parameters
http://stackoverflow.com/questions/812925/what-is-the-maximum-possible-length-of-a-query-string
http://stackoverflow.com/questions/7724270/max-size-of-url-parameters-in-get
This means that if we have a very long message etc and try to use a GET request, the request will likely be corrupt.
We can bypass this limitation by using a POST request.
Telegram supports four ways of passing parameters, but the most useful are:
application/x-www-form-urlencoded
multipart/form-data
(use to upload files)This PR, switches the normal requests to use POST instead of GET and ensure the parameters are passed via
application/x-www-form-urlencoded
If a file is being uploaded, it automatically knows to use
multipart/form-data
.No breaking changes.