Skip to content

Use POST requests when contacting the telegram api server. - #40

Merged
irazasyed merged 1 commit into
irazasyed:masterfrom
jonnywilliamson:postRequests
Sep 28, 2015
Merged

Use POST requests when contacting the telegram api server.#40
irazasyed merged 1 commit into
irazasyed:masterfrom
jonnywilliamson:postRequests

Conversation

@jonnywilliamson

Copy link
Copy Markdown
Contributor

Whilst a GET request according to the specs may have an unlimited number of characters, in practice it appears that different versions of PHP and even webbrowsers do have a limit.

http://stackoverflow.com/questions/3091485/what-is-the-limit-on-querystring-get-url-parameters
http://stackoverflow.com/questions/812925/what-is-the-maximum-possible-length-of-a-query-string
http://stackoverflow.com/questions/7724270/max-size-of-url-parameters-in-get

This means that if we have a very long message etc and try to use a GET request, the request will likely be corrupt.

We can bypass this limitation by using a POST request.

Telegram supports four ways of passing parameters, but the most useful are:

application/x-www-form-urlencoded
multipart/form-data (use to upload files)

This PR, switches the normal requests to use POST instead of GET and ensure the parameters are passed via application/x-www-form-urlencoded

If a file is being uploaded, it automatically knows to use multipart/form-data.

No breaking changes.

irazasyed added a commit that referenced this pull request Sep 28, 2015
Use POST requests when contacting the telegram api server.
@irazasyed
irazasyed merged commit 5716be4 into irazasyed:master Sep 28, 2015
@irazasyed

Copy link
Copy Markdown
Owner

Thank you @jonnywilliamson :)

@jonnywilliamson
jonnywilliamson deleted the postRequests branch September 28, 2015 11:55
@jonnywilliamson

Copy link
Copy Markdown
Contributor Author

@irazasyed No probs!

Any chance of a tag release?

@irazasyed

Copy link
Copy Markdown
Owner

Will do that sometime this week. Gotta do some testing of all the recent changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants