New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass through params from commandsHandler() to getUpdates() #418

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
2 participants
@Overtorment
Contributor

Overtorment commented Jul 24, 2017

I'm using $update = $telegram->commandsHandler(); in production and discovered that it doesn't use long polling. To make it use long polling I had to rewrite commandsHandler() with a call to getUpdates() with timeout parameter set.

It would be much simpler to passthrough timeout from the scope I'm calling commandsHandler() in the first place.
I.e. $update = $telegram->commandsHandler(false, ['timeout' => 30]);

@irazasyed irazasyed merged commit 32d56bd into irazasyed:master Aug 31, 2017

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@irazasyed

This comment has been minimized.

Show comment
Hide comment
@irazasyed

irazasyed Aug 31, 2017

Owner

Looks good. Thanks 👍

Owner

irazasyed commented Aug 31, 2017

Looks good. Thanks 👍

@Overtorment Overtorment deleted the Overtorment:dev-passthrough-from-commandshandler-to-getupdates branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment