Dependency Injection in commands constructors

[antoniomadonna]

Use Laravel Container Class to resolve commands type hinted dependencies.

[jonnywilliamson]

Just trying to follow this.

You want to use Laravel's IOC container so that you get automatic dependency injection when you create a class for a command?

So that

<?php

namespace App\Telegram\Bot\commands;

use App\Telegram\Bot\BotCommand;

class start extends BotCommand
{

    protected $demo;
    protected $example;

    public function __construct(Demo $demo, Example $example)
    {
        $this->demo = $demo;
        $this->example = $example;
    }

    protected $name = "start";

    protected $description = "start Description";

    public function handle($arguments)
    {
    }

}

Demo and Example are resolved for you automatically?

[antoniomadonna]

Yes, exactly.

But I've just discovered that I forgot to check if the constructor is available. I'll fix asap.

Il giorno 11/nov/2015, alle ore 18:30, Jonathan notifications@github.com ha scritto:

Just trying to follow this.

You want to use Laravel's IOC container so that you get automatic dependency injection when you create a class for a command?

So that

demo = $demo; $this->example = $example; } protected $name = "start"; protected $description = "start Description"; public function handle($arguments) { } ``` } Demo and Example are resolved for you automatically? — Reply to this email directly or view it on GitHub.

[irazasyed]

Hey @antoniomadonna

Thanks for opening a PR. I appreciate your contribution.

I'll test this once you push a fix and merge it if i don't find any issues. Looks good to me. 👍

[antoniomadonna]

ty @irazasyed

I've fixed the issue :)

[irazasyed]

@antoniomadonna Can you please rebase as per the latest changes in master branch?

Also, Please send a separate PR for each change (In this case, Tests should be in a separate PR). You have two different things pushed in one. Please update. Thanks!

[antoniomadonna]

@irazasyed sorry I'm new to contributing, this PR should be ok now, I'm going to submit the tests asap

[irazasyed]

@antoniomadonna No problem. Thanks for separating the PRs and for all the contributions :)