Added new tests and created a Mocking 'Telegram Response' class - #76
Merged
Conversation
Closed
Owner
|
Looks good to me 馃憤 |
irazasyed
added a commit
that referenced
this pull request
Dec 7, 2015
Added new tests and created a Mocking 'Telegram Response' class
|
Good job :) Moving to a different class seems cleaner. |
Owner
|
Mocker sounds good 馃憤 |
Contributor
Author
|
@antoniomadonna Yes, I'll move the class. Good idea. I toyed around with the name for ages, but here's what I thought. MocksProvider was too long, especially when we will be typing it alot. If everyone thinks Mocker is good I'll change it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for feedback on this.
Have never done testing before, so I'm sure there can be many improvements or better ways to do things. Please show me how! :)