Skip to content

Added new tests and created a Mocking 'Telegram Response' class - #76

Merged
irazasyed merged 1 commit into
irazasyed:masterfrom
jonnywilliamson:testing
Dec 7, 2015
Merged

Added new tests and created a Mocking 'Telegram Response' class#76
irazasyed merged 1 commit into
irazasyed:masterfrom
jonnywilliamson:testing

Conversation

@jonnywilliamson

Copy link
Copy Markdown
Contributor

Looking for feedback on this.

Have never done testing before, so I'm sure there can be many improvements or better ways to do things. Please show me how! :)

@jonnywilliamson jonnywilliamson mentioned this pull request Dec 6, 2015
@irazasyed

Copy link
Copy Markdown
Owner

Looks good to me 馃憤

irazasyed added a commit that referenced this pull request Dec 7, 2015
Added new tests and created a Mocking 'Telegram Response' class
@irazasyed
irazasyed merged commit 7772bf8 into irazasyed:master Dec 7, 2015
@antoniomadonna

Copy link
Copy Markdown

Good job :) Moving to a different class seems cleaner.
Maybe, I'd just rename TGMocks to something like MocksProvider, or Mocker, what you think ?
And perhaps it should be inside the Mocks dir ?

@irazasyed

Copy link
Copy Markdown
Owner

Mocker sounds good 馃憤

@jonnywilliamson
jonnywilliamson deleted the testing branch December 7, 2015 14:37
@jonnywilliamson

Copy link
Copy Markdown
Contributor Author

@antoniomadonna Yes, I'll move the class. Good idea.

I toyed around with the name for ages, but here's what I thought.

MocksProvider was too long, especially when we will be typing it alot.
Mocker....was there any risk of this being mistook for the Mockery Library?
ResponseGenerator - Too long
Generator - too ambiguous.
APIMock - ??

If everyone thinks Mocker is good I'll change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants