Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new tests and created a Mocking 'Telegram Response' class #76

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Added new tests and created a Mocking 'Telegram Response' class #76

merged 1 commit into from
Dec 7, 2015

Conversation

jonnywilliamson
Copy link
Contributor

Looking for feedback on this.

Have never done testing before, so I'm sure there can be many improvements or better ways to do things. Please show me how! :)

@jonnywilliamson jonnywilliamson mentioned this pull request Dec 6, 2015
@irazasyed
Copy link
Owner

Looks good to me 👍

irazasyed added a commit that referenced this pull request Dec 7, 2015
Added new tests and created a Mocking 'Telegram Response' class
@irazasyed irazasyed merged commit 7772bf8 into irazasyed:master Dec 7, 2015
@antoniomadonna
Copy link

Good job :) Moving to a different class seems cleaner.
Maybe, I'd just rename TGMocks to something like MocksProvider, or Mocker, what you think ?
And perhaps it should be inside the Mocks dir ?

@irazasyed
Copy link
Owner

Mocker sounds good 👍

@jonnywilliamson jonnywilliamson deleted the testing branch December 7, 2015 14:37
@jonnywilliamson
Copy link
Contributor Author

@antoniomadonna Yes, I'll move the class. Good idea.

I toyed around with the name for ages, but here's what I thought.

MocksProvider was too long, especially when we will be typing it alot.
Mocker....was there any risk of this being mistook for the Mockery Library?
ResponseGenerator - Too long
Generator - too ambiguous.
APIMock - ??

If everyone thinks Mocker is good I'll change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants