Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of docs for Version 2.0 Release #89

Merged
merged 8 commits into from
Dec 24, 2015
Merged

First draft of docs for Version 2.0 Release #89

merged 8 commits into from
Dec 24, 2015

Conversation

jonnywilliamson
Copy link
Contributor

The beginnings of some document updates for the release of V2.

Due to rapid amount of changes Telegram have made to their method parameter names and order, this version now requires all main methods to be called with an _array of parameters_ rather than _individual parameters_.
```
The affected methods are:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this outside of the backticks and give a single blank line break.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@irazasyed
Copy link
Owner

Thanks for the contributions as always. I've just commented on a few things where some revision is required. Please take a look.

irazasyed added a commit that referenced this pull request Dec 24, 2015
First draft of docs for Version 2.0 Release
@irazasyed irazasyed merged commit 1b4bfc5 into irazasyed:master Dec 24, 2015
@irazasyed
Copy link
Owner

Merged. Thanks again :)

@jonnywilliamson
Copy link
Contributor Author

Didn't think you'd be merging this just yet! Does it auto create the html docs?

@irazasyed
Copy link
Owner

Nope. Will have to generate using a command. I'll do that if we're fully done with docs?

@irazasyed
Copy link
Owner

P.S Should've squashed the commits. Just saw the log and it looks ugly.

@jonnywilliamson
Copy link
Contributor Author

I commit as I go along! Didn't know you were going to merge. Do a force push if you want. Very few if any will have pulled yet.

@irazasyed
Copy link
Owner

Okay!

It looked good, So didn't see any reason to not merge it.

@irazasyed
Copy link
Owner

Done!

For some reason (I think my first attempt caused this issue), The other commits too got rebased (Nothing changed though). Now it shows my name too.

@jonnywilliamson
Copy link
Contributor Author

Cool. I think I'll get over not seeing my name on the commit list!

@irazasyed
Copy link
Owner

You don't see your name :O?

I can see your name, what's up?

@jonnywilliamson jonnywilliamson deleted the newdocs branch December 27, 2015 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants