Set real name correctly #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add optional irc.user field, which defaults to nick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for making irccat. I been using it for a few months now to provide a project news feed to a channel on Libera.Chat. It's worked amazingly so far. One thing I've noticed is that the
irc.realnameoption is passed as the initial "ident/user" arg in the IRC commandUSER <arg> 0 * :<realname>. So, specifying a value like"My Bot"ends up giving a userhost ofmynick!~My@example.comand a realname of0.0.0.0(which is whatgo-irceventspecifies for the default second and third args). Tweaking how things are wired up a bit seems to make the problem go away. Thanks again.