Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix php.sh to support double quotes #24

Merged
merged 1 commit into from Nov 19, 2013
Merged

fix php.sh to support double quotes #24

merged 1 commit into from Nov 19, 2013

Conversation

igorw
Copy link
Collaborator

@igorw igorw commented Nov 17, 2013

The current script loses double quotes, meaning this will fail:

$ ./php.sh -r 'var_dump("hello");'

I was not sure if there was a reason for the -c subshell. Hence the PR. If that needs to stay, an alternate fix would be:

PARAMS="${PARAMS} \"${PARAM//\"/\\\"}\""

(from here, lol bash)

@asm89
Copy link

asm89 commented Nov 17, 2013

👍, "\$@" will just pass the values properly escaped.

Or is there a specific reason to do bash -c ?

ircmaxell added a commit that referenced this pull request Nov 19, 2013
fix php.sh to support double quotes
@ircmaxell ircmaxell merged commit 6d5d62a into master Nov 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants