New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WHOX on netsplit advice #146

Merged
merged 3 commits into from May 11, 2015

Conversation

Projects
None yet
3 participants
@jwheare
Member

jwheare commented Apr 29, 2015

WHO after netsplit is unnecessary in the context of account-notify. All the rejoins after netsplit will include the relevant account information in extended-join.

@dequis

This comment has been minimized.

Show comment
Hide comment
@dequis

dequis Apr 29, 2015

Contributor

I guess there should be an errata section mentioning this removal, like PR #139 did

Contributor

dequis commented Apr 29, 2015

I guess there should be an errata section mentioning this removal, like PR #139 did

Show outdated Hide outdated extensions/account-notify-3.1.md
A previous version of this specification advised making a WHO request following a netsplit.
This advice was deemed unnecessary and was removed. See
[issue #134](https://github.com/ircv3/ircv3-specifications/issues/146) for more information, including

This comment has been minimized.

@dequis

dequis Apr 29, 2015

Contributor

Link text says 134 (also this issue doesn't really add a lot of information atm)

@dequis

dequis Apr 29, 2015

Contributor

Link text says 134 (also this issue doesn't really add a lot of information atm)

This comment has been minimized.

@jwheare

jwheare Apr 29, 2015

Member

Oops, and I did add a rationale in the description though.

@jwheare

jwheare Apr 29, 2015

Member

Oops, and I did add a rationale in the description though.

@jwheare

This comment has been minimized.

Show comment
Hide comment
@jwheare

jwheare May 11, 2015

Member

Don't think this is a controversial change. Can we get a merge?

Member

jwheare commented May 11, 2015

Don't think this is a controversial change. Can we get a merge?

grawity added a commit that referenced this pull request May 11, 2015

Merge pull request #146 from jwheare/patch-2
Remove WHOX on netsplit advice

@grawity grawity merged commit 5f110ce into ircv3:master May 11, 2015

@jwheare jwheare deleted the jwheare:patch-2 branch Jul 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment