Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WHOX on netsplit advice #146

Merged
merged 3 commits into from May 11, 2015
Merged

Remove WHOX on netsplit advice #146

merged 3 commits into from May 11, 2015

Conversation

jwheare
Copy link
Member

@jwheare jwheare commented Apr 29, 2015

WHO after netsplit is unnecessary in the context of account-notify. All the rejoins after netsplit will include the relevant account information in extended-join.

@dequis
Copy link
Contributor

dequis commented Apr 29, 2015

I guess there should be an errata section mentioning this removal, like PR #139 did


A previous version of this specification advised making a WHO request following a netsplit.
This advice was deemed unnecessary and was removed. See
[issue #134](https://github.com/ircv3/ircv3-specifications/issues/146) for more information, including
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link text says 134 (also this issue doesn't really add a lot of information atm)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, and I did add a rationale in the description though.

@jwheare
Copy link
Member Author

jwheare commented May 11, 2015

Don't think this is a controversial change. Can we get a merge?

grawity added a commit that referenced this pull request May 11, 2015
Remove WHOX on netsplit advice
@grawity grawity merged commit 5f110ce into ircv3:master May 11, 2015
@jwheare jwheare deleted the patch-2 branch July 18, 2015 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants