Remove WHOX on netsplit advice #146
Merged
Conversation
|
I guess there should be an errata section mentioning this removal, like PR #139 did |
extensions/account-notify-3.1.md
Outdated
|
|
||
| A previous version of this specification advised making a WHO request following a netsplit. | ||
| This advice was deemed unnecessary and was removed. See | ||
| [issue #134](https://github.com/ircv3/ircv3-specifications/issues/146) for more information, including |
dequis
Apr 29, 2015
Contributor
Link text says 134 (also this issue doesn't really add a lot of information atm)
Link text says 134 (also this issue doesn't really add a lot of information atm)
jwheare
Apr 29, 2015
Author
Member
Oops, and I did add a rationale in the description though.
Oops, and I did add a rationale in the description though.
|
Don't think this is a controversial change. Can we get a merge? |
grawity
added a commit
that referenced
this pull request
May 11, 2015
Remove WHOX on netsplit advice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
WHO after netsplit is unnecessary in the context of account-notify. All the rejoins after netsplit will include the relevant account information in extended-join.