Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap Clarifications #371

Merged
merged 4 commits into from Jan 30, 2020
Merged

Cap Clarifications #371

merged 4 commits into from Jan 30, 2020

Conversation

@DanielOaks
Copy link
Member

DanielOaks commented Feb 22, 2019

Clarifies some issues brought up with the CAP spec. Specifically, fixes #368 and #369, and adds some language along the lines of that suggested by jw in #359.

These clarifications should make CAP more future-proof and consistent.

I'm not quite happy with the "approaching the 510 byte limit" fragment of text in particular, but will continue editing it up. If anyone has recommendations, open to 'em!

@jwheare

This comment has been minimized.

Copy link
Member

jwheare commented Feb 22, 2019

The downgrade stuff should probably be a SHOULD/SHOULD NOT. There’s probably a bunch of implementations that get this “wrong” so I dunno if we can retroactively make this a hard requirement. Dunno, thoughts?

@jwheare jwheare added this to the Roadmap milestone Feb 26, 2019
@DanielOaks

This comment has been minimized.

Copy link
Member Author

DanielOaks commented Apr 3, 2019

Yeah that makes sense, I'll update that language

core/capability-negotiation.md Outdated Show resolved Hide resolved
core/capability-negotiation.md Outdated Show resolved Hide resolved
SadieCat added a commit to SadieCat/inspircd that referenced this pull request Apr 19, 2019
This ensures compliance with the behaviour specified in ircv3/ircv3-specifications#371.
@jwheare

This comment has been minimized.

Copy link
Member

jwheare commented Jan 17, 2020

Is this good to go?

@jwheare jwheare merged commit 177ad30 into ircv3:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.