Cap Clarifications #371
Merged
Cap Clarifications #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The downgrade stuff should probably be a SHOULD/SHOULD NOT. There’s probably a bunch of implementations that get this “wrong” so I dunno if we can retroactively make this a hard requirement. Dunno, thoughts? |
|
Yeah that makes sense, I'll update that language |
xPaw
reviewed
Apr 3, 2019
grawity
reviewed
Apr 3, 2019
SadieCat
added a commit
to SadieCat/inspircd
that referenced
this issue
Apr 19, 2019
This ensures compliance with the behaviour specified in ircv3/ircv3-specifications#371.
|
Is this good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Clarifies some issues brought up with the CAP spec. Specifically, fixes #368 and #369, and adds some language along the lines of that suggested by jw in #359.
These clarifications should make CAP more future-proof and consistent.
I'm not quite happy with the "approaching the 510 byte limit" fragment of text in particular, but will continue editing it up. If anyone has recommendations, open to 'em!