Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratify labeled-response #378

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@DanielOaks
Copy link
Member

commented Apr 9, 2019

There's been a few server implementations of this and it looks pretty well stable from everything I've seen.


updated 2019-05-29 by @jwheare to add new links to PRs addressing blockers

  • #385 Label revisions (merged)
  • #386 ACK command for empty labeled responses

Known implementations

Unchecked means incomplete or an intent to implement has been expressed. The numbers indicate minimum requirements. Any others?

Server (2/2)

Client (1/2)

Bouncer

Bots

Networks

@jwheare

This comment has been minimized.

Copy link
Member

commented Apr 10, 2019

Still need to resolve this ircv3/ircv3-ideas#37

@jwheare jwheare added this to the Roadmap milestone Apr 29, 2019

This was referenced May 29, 2019

@jwheare

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Added PRs to address the blockers: #385 #386

@jwheare jwheare added the Blocked label May 31, 2019

@jesopo

This comment has been minimized.

Copy link

commented Jun 12, 2019

Both blockers are now merged

@jwheare

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

0.2 needs more implementations, I'll update the checkboxes.

@SaberUK

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

I have a 0.2 implementation for InspIRCd I just need to fix a few minor issues with it.

Update InspIRCd's implementation is now updated to 0.2, will be on the testnet shortly.

@slingamn

This comment has been minimized.

Copy link

commented Jun 13, 2019

I implemented this as oragono/oragono#557, but it missed the freeze deadline for our upcoming release (v1.1.0), so it'll have to go in after that. I can put it on darwin as soon as it hits the master branch.

@RyanSquared

This comment has been minimized.

Copy link

commented Jun 13, 2019

With regards to which sections of a batch should include a label, either the start, or the whole message:

07:04 <LordRyan> i think it would probably be better to say "clients shouldn't rely on messages inside the batch being tagged" because i have a feeling some server implementation is going to just tag all the messages, then wrap it in a batch and tag that batch as well
07:05 <LordRyan> so it wouldn't be a good idea to say something like "servers should not include label tags inside the batch", but it's important for clients to be capable of handling the behavior just in case

@jesopo

This comment has been minimized.

Copy link

commented Jun 13, 2019

If batch has not been enabled, the tag MAY be included on only one of the messages in the response.

I am quite uncomfortable with this. Can't we just demand that labeled-response comes with batch support?

<LordRyan> everyone who supports labeled-response supports batch (server-side), so I'd be comfortable with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.