Skip to content

Conversation

@SadieCat
Copy link
Contributor

@SadieCat SadieCat commented May 2, 2021

  • Update client spec support
  • Remove/replace some dead clients

@progval
Copy link
Contributor

progval commented May 2, 2021

Could you use a tag or commit id in links, instead of master? Links to master may break because files or code is moved.

@SadieCat
Copy link
Contributor Author

SadieCat commented May 2, 2021

Tag comments are kinda useless for referencing because when you go to update the list it just points to an old commit and you have to find the branch anyway.

@progval
Copy link
Contributor

progval commented May 2, 2021

but it's useful to provide a source for the existing data. And if someone wants to see the latest version, they can replace with master in the URL

- plain
- name: The Lounge
# ref: https://github.com/thelounge/thelounge/projects/1
# https://github.com/kiwiirc/irc-framework/blob/master/docs/ircv3.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not the wrong link. The Lounge uses irc-framework.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, my bad

@DanielOaks
Copy link
Member

Thanks for the PR, much appreciated! <3

@DanielOaks DanielOaks merged commit eca81d4 into ircv3:master May 2, 2021
@SadieCat SadieCat deleted the client-lists branch May 2, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants