-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ireec crash for mhlo.pad operator #9296
Comments
Why this is mhlo.pad op, not mhlo.slice op? The padding config is |
Let's file a bug for that canonicalization. And keep this one to the crash given this op. |
I don't have a strong opinion about whether this should be allowed by the MHLO spec, but right now it appears to be (in the sense that XLA accepts it if the IR is exported to XLA and that's as close as we have to a specification). We should either clarify the MHLO spec and disallow this, or implement it. And crashing isn't the right behavior either way... |
The spec has been updated here and the above input seems to be passing for me, so issue potentially resolved. (tested with tools/iree-compile \
--iree-input-type=mhlo \
--iree-vm-bytecode-module-output-format=flatbuffer-binary \
--iree-hal-target-backends=dylib \
--iree-mlir-to-vm-bytecode-module \
--mlir-print-debuginfo \
--mlir-pass-pipeline-crash-reproducer=/tmp/iree/core-reproducer.mlir \
9296.mlir -o /dev/null and flatbuffer was generated) |
Assigning to Jacques officially as this is labeled as a P1 issue. It may be resolved? |
Crash has been resolved. |
Output:
The text was updated successfully, but these errors were encountered: