Skip to content
Permalink
Browse files

Add exception for libassistant to import checker.

libassistant needs to be moved to third_party to fix the actual issue
but adding an exception is a quick fix that prevents constantly
seeing the false positive when working on a repo with Android and
Linux.

This fixes issues with "multiple definition" involving a class and
the same class in libassistant.

Change-Id: I5507bb3b969c03b521107ae3bf64742d13886301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802297
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#696237}
  • Loading branch information
Henrique Nakashima Commit Bot
Henrique Nakashima authored and Commit Bot committed Sep 13, 2019
1 parent 4b99431 commit a70956aaab88a148eb884d639debfe6c8fa8f610
Showing with 2 additions and 1 deletion.
  1. +2 −1 buildtools/checkdeps/java_checker.py
@@ -66,7 +66,8 @@ def _IgnoreDir(self, d):
# TODO(husky): We need some way of determining the "real" path to
# a generated file -- i.e., where it would be in source control if
# it weren't generated.
if d.startswith('out') or d in ('xcodebuild', 'AndroidStudioDefault',):
if d.startswith('out') or d in ('xcodebuild', 'AndroidStudioDefault',
'libassistant',):
return True
# Skip third-party directories.
if d in ('third_party', 'ThirdParty'):

0 comments on commit a70956a

Please sign in to comment.
You can’t perform that action at this time.