Skip to content
Browse files

Remove use of deprecated function v8::V8::SetNativesDataBlob

With the recent port of the streams API to C++ [0], the natives blob is
now unused and will shortly be removed. V8 API related to the natives
blob is being deprecated [1] and will be removed in the next release.

This CL is the minimal change to keep up with these API deprecations.

In follow-up work, all other infrastructure related to the natives blob
should be removed.


Bug: v8:7624
Change-Id: I26e409660d177035cdb5d92c317fc2e0174be2f7
Reviewed-by: Lei Zhang <>
Reviewed-by: Ross McIlroy <>
Auto-Submit: Jakob Gruber <>
Commit-Queue: Jakob Gruber <>
Cr-Commit-Position: refs/heads/master@{#702475}
  • Loading branch information
schuay authored and Commit Bot committed Oct 3, 2019
1 parent 9d04509 commit b4c21a0cba15b1c147b7fbd0b17b861d2675f449
Showing with 2 additions and 2 deletions.
  1. +1 −1 gin/
  2. +1 −1 pdf/
@@ -266,9 +266,9 @@ void V8Initializer::Initialize(IsolateHolder::ScriptMode mode) {

// TODO(v8:7624): Remove natives and all remaining infrastructure.
v8::StartupData natives;
GetMappedFileData(g_mapped_natives, &natives);

if (g_mapped_snapshot) {
v8::StartupData snapshot;
@@ -43,13 +43,13 @@ bool PDFModule::Init() {

pp::Instance* PDFModule::CreateInstance(PP_Instance instance) {
if (!g_sdk_initialized_via_pepper) {
// TODO(v8:7624): Remove natives and all remaining infrastructure.
v8::StartupData natives;
v8::StartupData snapshot;
&, &natives.raw_size,
&, &snapshot.raw_size);
if ( {

0 comments on commit b4c21a0

Please sign in to comment.
You can’t perform that action at this time.