Skip to content
Permalink
Browse files

Add prefix to empty param tests.

googletest will no longer support empty prefix
for parameterized INSTANTIATE_TEST_SUITE_P.
Adding "All" prefix to existing empty prefix test suites.

This CL was uploaded by git cl split.

R=davidben@chromium.org

Bug: 1023677
Change-Id: I1e603b764e4b0de635a7d5f811dd1aabbdeb42be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926849
Auto-Submit: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717378}
  • Loading branch information
isamsonov-g authored and Commit Bot committed Nov 21, 2019
1 parent cc0f7e3 commit ea7fffbc397a4023392cf97541d017f4f90946e0
Showing with 3 additions and 3 deletions.
  1. +1 −1 crypto/aead_unittest.cc
  2. +2 −2 crypto/symmetric_key_unittest.cc
@@ -17,7 +17,7 @@ const crypto::Aead::AeadAlgorithm kAllAlgorithms[]{

class AeadTest : public testing::TestWithParam<crypto::Aead::AeadAlgorithm> {};

INSTANTIATE_TEST_SUITE_P(, AeadTest, testing::ValuesIn(kAllAlgorithms));
INSTANTIATE_TEST_SUITE_P(All, AeadTest, testing::ValuesIn(kAllAlgorithms));

TEST_P(AeadTest, SealOpen) {
crypto::Aead::AeadAlgorithm alg = GetParam();
@@ -207,10 +207,10 @@ static const ScryptTestVector kTestVectorsScrypt[] = {
"7023bdcb3afd7348461c06cd81fd38ebfda8fbba904f8e3ea9b543f6545da1f2d54329556"
"13f0fcf62d49705242a9af9e61e85dc0d651e40dfcf017b45575887"}};

INSTANTIATE_TEST_SUITE_P(,
INSTANTIATE_TEST_SUITE_P(All,
SymmetricKeyDeriveKeyFromPasswordUsingPbkdf2Test,
testing::ValuesIn(kTestVectorsPbkdf2));

INSTANTIATE_TEST_SUITE_P(,
INSTANTIATE_TEST_SUITE_P(All,
SymmetricKeyDeriveKeyFromPasswordUsingScryptTest,
testing::ValuesIn(kTestVectorsScrypt));

0 comments on commit ea7fffb

Please sign in to comment.
You can’t perform that action at this time.