Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a last ditch effort to find a series name and season/episode numbers #60

Closed
IrishPrime opened this issue Apr 24, 2018 · 0 comments
Closed

Make a last ditch effort to find a series name and season/episode numbers #60

IrishPrime opened this issue Apr 24, 2018 · 0 comments
Assignees
@IrishPrime
Labels
enhancement

Comments

@IrishPrime
Copy link
Owner

Some files are named so poorly that it's either difficult to write a pattern to match them, or simply not worth doing because the odds of encountering them are so low. Add a pattern (or several) which attempts only to match the series name and season/episode numbers. With just that information, the rest can be fetched and the new file name can be constructed.
@IrishPrime IrishPrime self-assigned this Apr 24, 2018
IrishPrime added a commit that referenced this issue Apr 29, 2018
@IrishPrime
Add "last ditch effort" pattern
d601f06 
- Add a pattern which attempts to recognize a series name, season, and
  episode number without much structure in the format beyond that order.
  With those three pieces of information, the title can be fetched. Note
  to self, this is probably how the project should have started.
- Add a test case for the new pattern.
- Add the series ID for "Limitless" since it's used in the new test.
- Use the `groupdict` function to build the file information dictionary
  in a somewhat more automatic way.
- Address some standards failings and linting issues (namely, overly
  terse variable names and string interpolation for log messages).
- Bump the minor version number.
- Resolves #60.
@IrishPrime IrishPrime mentioned this issue Apr 29, 2018
Merged
IrishPrime added a commit that referenced this issue Apr 29, 2018
@IrishPrime
Add "last ditch effort" pattern (#61)
e853f9a 
- Add a pattern which attempts to recognize a series name, season, and
  episode number without much structure in the format beyond that order.
  With those three pieces of information, the title can be fetched. Note
  to self, this is probably how the project should have started.
- Add a test case for the new pattern.
- Add the series ID for "Limitless" since it's used in the new test.
- Use the `groupdict` function to build the file information dictionary
  in a somewhat more automatic way.
- Address some standards failings and linting issues (namely, overly
  terse variable names and string interpolation for log messages).
- Bump the minor version number.
- Resolves #60.
IrishPrime added a commit that referenced this issue Feb 23, 2019
@IrishPrime
Add "last ditch effort" pattern (#61)
404c2f7 
- Add a pattern which attempts to recognize a series name, season, and
  episode number without much structure in the format beyond that order.
  With those three pieces of information, the title can be fetched. Note
  to self, this is probably how the project should have started.
- Add a test case for the new pattern.
- Add the series ID for "Limitless" since it's used in the new test.
- Use the `groupdict` function to build the file information dictionary
  in a somewhat more automatic way.
- Address some standards failings and linting issues (namely, overly
  terse variable names and string interpolation for log messages).
- Bump the minor version number.
- Resolves #60.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IrishPrime IrishPrime

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IrishPrime