From 446f60cff1f04bdc780319ce553815dd89ecd9ad Mon Sep 17 00:00:00 2001 From: Mauro Passerino Date: Tue, 14 Feb 2023 10:00:41 -0300 Subject: [PATCH] Add logs on failed take response/request --- rclcpp/src/rclcpp/client.cpp | 4 ++++ rclcpp/src/rclcpp/service.cpp | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/rclcpp/src/rclcpp/client.cpp b/rclcpp/src/rclcpp/client.cpp index 0bbc378aea..74dfbed099 100644 --- a/rclcpp/src/rclcpp/client.cpp +++ b/rclcpp/src/rclcpp/client.cpp @@ -80,6 +80,10 @@ ClientBase::take_type_erased_response(void * response_out, rmw_request_id_t & re &request_header_out, response_out); if (RCL_RET_CLIENT_TAKE_FAILED == ret) { + RCLCPP_ERROR( + rclcpp::get_logger("rclcpp"), + "Error in take_type_erased_response: RCL_RET_CLIENT_TAKE_FAILED. " + "Service name: %s", get_service_name()); return false; } else if (RCL_RET_OK != ret) { rclcpp::exceptions::throw_from_rcl_error(ret); diff --git a/rclcpp/src/rclcpp/service.cpp b/rclcpp/src/rclcpp/service.cpp index 805a4525a7..d9e678149f 100644 --- a/rclcpp/src/rclcpp/service.cpp +++ b/rclcpp/src/rclcpp/service.cpp @@ -43,6 +43,10 @@ ServiceBase::take_type_erased_request(void * request_out, rmw_request_id_t & req &request_id_out, request_out); if (RCL_RET_SERVICE_TAKE_FAILED == ret) { + RCLCPP_ERROR( + rclcpp::get_logger("rclcpp"), + "Error in take_type_erased_request: RCL_RET_SERVICE_TAKE_FAILED. " + "Service name: %s", get_service_name()); return false; } else if (RCL_RET_OK != ret) { rclcpp::exceptions::throw_from_rcl_error(ret);