Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive collection iterator does not iterate over all sub-collections #4346

Closed
korydraughn opened this issue Apr 10, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@korydraughn
Copy link
Contributor

commented Apr 10, 2019

  • master
  • 4-2-stable

The following code does not visit every entry under collection_path.

namespace fs = irods::experimental::filesystem::[server, client];
for (auto&& e : fs::recursive_collection_iterator{conn, collection_path}) {
    // Do something with entry ...
}

This fails due to the incorrect implementation of the is_collection_empty(...) free function.

@korydraughn korydraughn added the bug label Apr 10, 2019

@korydraughn korydraughn self-assigned this Apr 10, 2019

korydraughn added a commit to korydraughn/irods that referenced this issue Apr 11, 2019

[irods#4346] Corrected is_empty implementation for recursive collecti…
…on iterators.

- Added unit tests for collection iterators.

korydraughn added a commit to korydraughn/irods that referenced this issue Apr 11, 2019

korydraughn added a commit to korydraughn/irods that referenced this issue Apr 11, 2019

[irods#4346] Corrected is_empty implementation for recursive collecti…
…on iterators.

- Added unit tests for collection iterators.

trel added a commit that referenced this issue Apr 11, 2019

trel added a commit that referenced this issue Apr 11, 2019

[#4346] Corrected is_empty implementation for recursive collection it…
…erators.

- Added unit tests for collection iterators.

@trel trel added this to the 4.2.6 milestone Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.